* [PATCH] Cygwin: pty: Change the timing of setup_locale() call.
@ 2020-08-13 5:42 Takashi Yano
2020-08-13 8:21 ` Corinna Vinschen
0 siblings, 1 reply; 2+ messages in thread
From: Takashi Yano @ 2020-08-13 5:42 UTC (permalink / raw)
To: cygwin-patches
- If native app is exec()'ed in a new pty, setup_locale() loses the
chance to be called. For example, with "mintty -e cmd", charset
conversion does not work as expected. This patch fixes the issue.
---
winsup/cygwin/fhandler_tty.cc | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/winsup/cygwin/fhandler_tty.cc b/winsup/cygwin/fhandler_tty.cc
index 92449ad7e..40b79bfbb 100644
--- a/winsup/cygwin/fhandler_tty.cc
+++ b/winsup/cygwin/fhandler_tty.cc
@@ -2983,6 +2983,10 @@ fhandler_pty_slave::fixup_after_fork (HANDLE parent)
// fork_fixup (parent, inuse, "inuse");
// fhandler_pty_common::fixup_after_fork (parent);
report_tty_counts (this, "inherited", "");
+
+ /* Set locale */
+ if (get_ttyp ()->term_code_page == 0)
+ setup_locale ();
}
void
@@ -3020,10 +3024,6 @@ fhandler_pty_slave::fixup_after_exec ()
}
}
- /* Set locale */
- if (get_ttyp ()->term_code_page == 0)
- setup_locale ();
-
/* Hook Console API */
if (get_pseudo_console ())
{
--
2.27.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Cygwin: pty: Change the timing of setup_locale() call.
2020-08-13 5:42 [PATCH] Cygwin: pty: Change the timing of setup_locale() call Takashi Yano
@ 2020-08-13 8:21 ` Corinna Vinschen
0 siblings, 0 replies; 2+ messages in thread
From: Corinna Vinschen @ 2020-08-13 8:21 UTC (permalink / raw)
To: cygwin-patches
On Aug 13 14:42, Takashi Yano via Cygwin-patches wrote:
> - If native app is exec()'ed in a new pty, setup_locale() loses the
> chance to be called. For example, with "mintty -e cmd", charset
> conversion does not work as expected. This patch fixes the issue.
> ---
> winsup/cygwin/fhandler_tty.cc | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/winsup/cygwin/fhandler_tty.cc b/winsup/cygwin/fhandler_tty.cc
> index 92449ad7e..40b79bfbb 100644
> --- a/winsup/cygwin/fhandler_tty.cc
> +++ b/winsup/cygwin/fhandler_tty.cc
> @@ -2983,6 +2983,10 @@ fhandler_pty_slave::fixup_after_fork (HANDLE parent)
> // fork_fixup (parent, inuse, "inuse");
> // fhandler_pty_common::fixup_after_fork (parent);
> report_tty_counts (this, "inherited", "");
> +
> + /* Set locale */
> + if (get_ttyp ()->term_code_page == 0)
> + setup_locale ();
> }
>
> void
> @@ -3020,10 +3024,6 @@ fhandler_pty_slave::fixup_after_exec ()
> }
> }
>
> - /* Set locale */
> - if (get_ttyp ()->term_code_page == 0)
> - setup_locale ();
> -
> /* Hook Console API */
> if (get_pseudo_console ())
> {
> --
> 2.27.0
Pushed.
Thanks,
Corinna
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-08-13 8:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-13 5:42 [PATCH] Cygwin: pty: Change the timing of setup_locale() call Takashi Yano
2020-08-13 8:21 ` Corinna Vinschen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).