public inbox for cygwin-patches@cygwin.com
 help / color / mirror / Atom feed
From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin-patches@cygwin.com
Subject: Re: [PATCH] Cygwin: cwdstuff::get: clean up debug_printf output
Date: Mon, 24 Aug 2020 11:07:31 +0200	[thread overview]
Message-ID: <20200824090731.GY3272@calimero.vinschen.de> (raw)
In-Reply-To: <20200823225103.22835-1-kbrown@cornell.edu>

On Aug 23 18:51, Ken Brown via Cygwin-patches wrote:
> Set errno = 0 at the beginning so that the debug_printf call at the
> end doesn't report a nonzero errno left over from some other function
> call.
> ---
>  winsup/cygwin/path.cc | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/winsup/cygwin/path.cc b/winsup/cygwin/path.cc
> index f3b9913bd..95faf8ca7 100644
> --- a/winsup/cygwin/path.cc
> +++ b/winsup/cygwin/path.cc
> @@ -5022,6 +5022,8 @@ char *
>  cwdstuff::get (char *buf, int need_posix, int with_chroot, unsigned ulen)
>  {
>    tmp_pathbuf tp;
> +
> +  errno = 0;
>    if (ulen)
>      /* nothing */;
>    else if (buf == NULL)
> -- 
> 2.28.0

Please push.


Thanks,
Corinna

      reply	other threads:[~2020-08-24  9:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-23 22:51 Ken Brown
2020-08-24  9:07 ` Corinna Vinschen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200824090731.GY3272@calimero.vinschen.de \
    --to=corinna-cygwin@cygwin.com \
    --cc=cygwin-patches@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).