public inbox for cygwin-patches@cygwin.com
 help / color / mirror / Atom feed
From: Takashi Yano <takashi.yano@nifty.ne.jp>
To: cygwin-patches@cygwin.com
Subject: Re: [PATCH] Cygwin: pty: Disable pseudo console if TERM is dumb or not set.
Date: Thu, 27 Aug 2020 13:07:20 +0900	[thread overview]
Message-ID: <20200827130720.f9f618c1313e18848a995f8c@nifty.ne.jp> (raw)
In-Reply-To: <20200826173606.GP3272@calimero.vinschen.de>

On Wed, 26 Aug 2020 19:36:06 +0200
Corinna Vinschen wrote:
> On Aug 26 21:00, Takashi Yano via Cygwin-patches wrote:
> > Pseudo console generates escape sequences on execution of non-cygwin
> > apps.  If the terminal does not support escape sequence, output will
> > be garbled. This patch prevents garbled output in dumb terminal by
> > disabling pseudo console.
> 
> I'm a bit puzzled by this patch.  We had code handling emacs and dumb
> terminals explicitely in the early forms of the first incarnation of
> the pseudo tty code, but fortunately you found a way to handle this
> without hardcoding terminal types into Cygwin.  Why do you think we
> have to do this now?

What previously disccussed was the problem that the clearing
screen at pty startup displays garbage (^[[H^[[2J) in emacs.
Finally, this was settled by eliminating clear-screen and
triggering redraw-screen instead at the first execution of
non-cygwin app.

However, the problem reported in
https://cygwin.com/pipermail/cygwin/2020-August/245983.html
still remains. 

What's worse in the new implementation, pseudo console sends
ESC[6n (querying cursor position) internally on startup and
waits for a response. This causes hang if pseudo console is
started in dumb terminal.

This patch is for fixing this issue.

-- 
Takashi Yano <takashi.yano@nifty.ne.jp>

  reply	other threads:[~2020-08-27  4:07 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-26 12:00 Takashi Yano
2020-08-26 17:36 ` Corinna Vinschen
2020-08-27  4:07   ` Takashi Yano [this message]
2020-08-27  8:47     ` Corinna Vinschen
2020-08-27  8:59       ` Takashi Yano
2020-08-27  9:05         ` Corinna Vinschen
2020-08-28 13:45 ` Corinna Vinschen
2020-08-28 19:25   ` Takashi Yano
2020-08-29 11:12     ` Takashi Yano
2020-08-29 13:14       ` Takashi Yano
2020-08-29 20:25         ` Takashi Yano
2020-08-29 21:13           ` Takashi Yano
2020-08-30  7:42             ` Takashi Yano
2020-08-30  7:58               ` Takashi Yano
2020-08-30 12:49       ` Corinna Vinschen
2020-08-31  3:26         ` Takashi Yano
2020-08-31  8:16           ` Corinna Vinschen
2020-08-31  9:47             ` Takashi Yano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200827130720.f9f618c1313e18848a995f8c@nifty.ne.jp \
    --to=takashi.yano@nifty.ne.jp \
    --cc=cygwin-patches@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).