From: Ken Brown <kbrown@cornell.edu>
To: cygwin-patches@cygwin.com
Subject: [PATCH 0/2] Fix problems with /proc/<pid>/fd checking
Date: Tue, 8 Sep 2020 12:50:46 -0400 [thread overview]
Message-ID: <20200908165048.47566-1-kbrown@cornell.edu> (raw)
This fixes the assertion failure reported here:
https://sourceware.org/pipermail/cygwin/2020-September/246160.html
with a simple test case here:
https://sourceware.org/pipermail/cygwin/2020-September/246188.html
That test case now fails as follows, as on Linux:
$ ./proc_bug.exe
open: Not a directory
I'm not completely sure about the second patch. The path_conv::check
code is so complicated that I could easily have missed something. But
I think it's correct.
Ken Brown (2):
Cygwin: format_process_fd: add directory check
Cygwin: path_conv::check: handle error from fhandler_process::exists
winsup/cygwin/fhandler_process.cc | 15 +++++++++++++++
winsup/cygwin/path.cc | 6 ++++++
2 files changed, 21 insertions(+)
--
2.28.0
next reply other threads:[~2020-09-08 16:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-08 16:50 Ken Brown [this message]
2020-09-08 16:50 ` [PATCH 1/2] Cygwin: format_process_fd: add directory check Ken Brown
2020-09-08 19:13 ` Corinna Vinschen
2020-09-08 16:50 ` [PATCH 2/2] Cygwin: path_conv::check: handle error from fhandler_process::exists Ken Brown
2020-09-08 18:57 ` Ken Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200908165048.47566-1-kbrown@cornell.edu \
--to=kbrown@cornell.edu \
--cc=cygwin-patches@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).