From: Jon Turney <jon.turney@dronecode.org.uk>
To: cygwin-patches@cygwin.com
Cc: Jon Turney <jon.turney@dronecode.org.uk>
Subject: [PATCH 3/8] Remove AC_PROG_MAKE_SET
Date: Mon, 12 Oct 2020 20:29:38 +0100 [thread overview]
Message-ID: <20201012192943.15732-4-jon.turney@dronecode.org.uk> (raw)
In-Reply-To: <20201012192943.15732-1-jon.turney@dronecode.org.uk>
This is only needed if we are using an ancient make which doesn't set
${MAKE}, but we say "This makefile requires GNU make." everywhere.
It only has an effect if @SET_MAKE@ is used, which we aren't doing
consistently.
---
winsup/configure.ac | 2 --
winsup/cygserver/configure.ac | 2 --
winsup/cygwin/Makefile.in | 2 --
winsup/cygwin/configure.ac | 2 --
4 files changed, 8 deletions(-)
diff --git a/winsup/configure.ac b/winsup/configure.ac
index 131dc79ee..e917ee1c5 100644
--- a/winsup/configure.ac
+++ b/winsup/configure.ac
@@ -43,7 +43,5 @@ INSTALL_LICENSE="install-license"
AC_SUBST(INSTALL_LICENSE)
-AC_PROG_MAKE_SET
-
AC_CONFIG_FILES([Makefile])
AC_OUTPUT
diff --git a/winsup/cygserver/configure.ac b/winsup/cygserver/configure.ac
index 560de0c05..d8b2a61fa 100644
--- a/winsup/cygserver/configure.ac
+++ b/winsup/cygserver/configure.ac
@@ -55,8 +55,6 @@ AC_CHECK_TOOL(NM, nm, nm)
AC_CHECK_TOOL(DLLTOOL, dlltool, dlltool)
AC_CHECK_TOOL(WINDRES, windres, windres)
-AC_PROG_MAKE_SET
-
AC_ARG_ENABLE(debugging,
[ --enable-debugging Build a cygwin DLL which has more consistency checking for debugging],
[case "${enableval}" in
diff --git a/winsup/cygwin/Makefile.in b/winsup/cygwin/Makefile.in
index 3a7a73adb..7f19a57fd 100644
--- a/winsup/cygwin/Makefile.in
+++ b/winsup/cygwin/Makefile.in
@@ -94,8 +94,6 @@ STRIP:=@STRIP@
LDSCRIPT:=cygwin.sc
MKDIRP:=$(INSTALL) -m 755 -d
-@SET_MAKE@
-
# Setup the testing framework, if you have one
EXPECT = `if [ -f $${rootme}/../../expect/expect$(EXEEXT) ] ; then \
echo $${rootme}/../../expect/expect$(EXEEXT) ; \
diff --git a/winsup/cygwin/configure.ac b/winsup/cygwin/configure.ac
index ff12dc259..ac019c94e 100644
--- a/winsup/cygwin/configure.ac
+++ b/winsup/cygwin/configure.ac
@@ -59,8 +59,6 @@ AC_CHECK_TOOL(RANLIB, ranlib, ranlib)
AC_CHECK_TOOL(STRIP, strip, strip)
AC_CHECK_TOOL(WINDRES, windres, windres)
-AC_PROG_MAKE_SET
-
AC_ARG_ENABLE(debugging,
[ --enable-debugging Build a cygwin DLL which has more consistency checking for debugging],
[case "${enableval}" in
--
2.28.0
next prev parent reply other threads:[~2020-10-12 19:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-12 19:29 [PATCH 0/8] Makefile/configure cleanups Jon Turney
2020-10-12 19:29 ` [PATCH 1/8] Drop looking for w32api in winsup/w32api Jon Turney
2020-10-12 19:29 ` [PATCH 2/8] Drop STDINCFLAGS overrides Jon Turney
2020-10-13 12:10 ` Corinna Vinschen
2020-10-13 17:36 ` Jon Turney
2020-10-13 18:11 ` Corinna Vinschen
2020-10-12 19:29 ` Jon Turney [this message]
2020-10-12 19:29 ` [PATCH 4/8] Remove AC_ARG_PROGRAM/program_transform_name Jon Turney
2020-10-12 19:29 ` [PATCH 5/8] Drop AC_SUBST(LIBSERVER) Jon Turney
2020-10-12 19:29 ` [PATCH 6/8] Remove autoconf variable INSTALL_LICENSE Jon Turney
2020-10-12 19:29 ` [PATCH 7/8] Remove empty MT_SAFE and MT_SAFE_OBJECTS Jon Turney
2020-10-12 19:29 ` [PATCH 8/8] Remove unused doc/ug-info.xml Jon Turney
2020-10-13 12:10 ` [PATCH 0/8] Makefile/configure cleanups Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201012192943.15732-4-jon.turney@dronecode.org.uk \
--to=jon.turney@dronecode.org.uk \
--cc=cygwin-patches@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).