From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin-patches@cygwin.com
Subject: Re: [PATCH] Cygwin: pty: Add workaround for ISO-2022 and ISCII in convert_mb_str().
Date: Tue, 13 Oct 2020 13:44:54 +0200 [thread overview]
Message-ID: <20201013114454.GI26704@calimero.vinschen.de> (raw)
In-Reply-To: <20200912041116.71e276467eaa4040c329547d@nifty.ne.jp>
On Sep 12 04:11, Takashi Yano via Cygwin-patches wrote:
> On Fri, 11 Sep 2020 20:57:06 +0200
> Corinna Vinschen wrote:
> > On Sep 12 03:37, Takashi Yano via Cygwin-patches wrote:
> > > On Sat, 12 Sep 2020 02:38:43 +0900
> > > Takashi Yano via Cygwin-patches <cygwin-patches@cygwin.com> wrote:
> > > > How about the patch attached?
> > > > I think this is safer than previous patch.
> > >
> > > I have revised this patch to fit current git head, and submit
> > > to cygwin-patches@cygwin.com.
> >
> > Thanks, but I didn't apply this one because it doesn't really make sense
> > to go to the extra effort to support outdated and incompatible codepages
> > we don't handle as Cygwin codeset at all. IMHO it's not worth to call
> > another MBTWC just to check if a codepage supports the MB_ERR_INVALID_CHARS
> > flag.
>
> I have checked which codepage does not support MB_ERR_INVALID_CHARS.
> The result is as follows.
>
> 42
> 50220
> 50221
> 50222
> 50225
> 50227
> 50229
> 52936
> 57002
> 57003
> 57004
> 57005
> 57006
> 57007
> 57008
> 57009
> 57010
> 57011
> 65000
Yup, these are documented on MSDN:
https://docs.microsoft.com/en-us/windows/win32/api/stringapiset/nf-stringapiset-widechartomultibyte
> If all of these are not worth for everyone, I agree with you.
I think we can skip those.
Corinna
next prev parent reply other threads:[~2020-10-13 11:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-11 10:54 Takashi Yano
2020-09-11 12:08 ` Corinna Vinschen
2020-09-11 12:35 ` Takashi Yano
2020-09-11 14:06 ` Corinna Vinschen
2020-09-11 15:10 ` Thomas Wolff
2020-09-11 15:18 ` Thomas Wolff
2020-09-11 16:05 ` Takashi Yano
2020-09-11 17:38 ` Takashi Yano
2020-09-11 18:37 ` Takashi Yano
2020-09-11 18:57 ` Corinna Vinschen
2020-09-11 19:11 ` Takashi Yano
2020-10-13 11:44 ` Corinna Vinschen [this message]
2020-09-11 18:14 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201013114454.GI26704@calimero.vinschen.de \
--to=corinna-cygwin@cygwin.com \
--cc=cygwin-patches@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).