From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin-patches@cygwin.com
Subject: Re: [PATCH 0/8] Makefile/configure cleanups
Date: Tue, 13 Oct 2020 14:10:39 +0200 [thread overview]
Message-ID: <20201013121039.GM26704@calimero.vinschen.de> (raw)
In-Reply-To: <20201012192943.15732-1-jon.turney@dronecode.org.uk>
On Oct 12 20:29, Jon Turney wrote:
> Some Makefile.in and configure.ac cleanups and de-cruftification. This is
> preparatory to an Automakeification series still being worked on.
>
> For ease of reviewing, this patch doesn't contain changes to generated files
> which would be made by a autoreconf.
>
> Jon Turney (8):
> Drop looking for w32api in winsup/w32api
> Drop STDINCFLAGS overrides
> Remove AC_PROG_MAKE_SET
> Remove AC_ARG_PROGRAM/program_transform_name
> Drop AC_SUBST(LIBSERVER)
> Remove autoconf variable INSTALL_LICENSE
> Remove empty MT_SAFE and MT_SAFE_OBJECTS
> Remove unused doc/ug-info.xml
>
> winsup/Makefile.in | 4 +---
> winsup/acinclude.m4 | 2 --
> winsup/configure.ac | 6 ------
> winsup/cygserver/configure.ac | 2 --
> winsup/cygwin/Makefile.in | 9 ---------
> winsup/cygwin/configure.ac | 18 ------------------
> winsup/doc/ug-info.xml | 36 -----------------------------------
> winsup/lsaauth/configure.ac | 2 --
> winsup/utils/Makefile.in | 4 +---
> winsup/utils/configure.ac | 2 --
> 10 files changed, 2 insertions(+), 83 deletions(-)
> delete mode 100644 winsup/doc/ug-info.xml
>
> --
> 2.28.0
Apart from my single, minor nit, LGTM.
Corinna
prev parent reply other threads:[~2020-10-13 12:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-12 19:29 Jon Turney
2020-10-12 19:29 ` [PATCH 1/8] Drop looking for w32api in winsup/w32api Jon Turney
2020-10-12 19:29 ` [PATCH 2/8] Drop STDINCFLAGS overrides Jon Turney
2020-10-13 12:10 ` Corinna Vinschen
2020-10-13 17:36 ` Jon Turney
2020-10-13 18:11 ` Corinna Vinschen
2020-10-12 19:29 ` [PATCH 3/8] Remove AC_PROG_MAKE_SET Jon Turney
2020-10-12 19:29 ` [PATCH 4/8] Remove AC_ARG_PROGRAM/program_transform_name Jon Turney
2020-10-12 19:29 ` [PATCH 5/8] Drop AC_SUBST(LIBSERVER) Jon Turney
2020-10-12 19:29 ` [PATCH 6/8] Remove autoconf variable INSTALL_LICENSE Jon Turney
2020-10-12 19:29 ` [PATCH 7/8] Remove empty MT_SAFE and MT_SAFE_OBJECTS Jon Turney
2020-10-12 19:29 ` [PATCH 8/8] Remove unused doc/ug-info.xml Jon Turney
2020-10-13 12:10 ` Corinna Vinschen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201013121039.GM26704@calimero.vinschen.de \
--to=corinna-cygwin@cygwin.com \
--cc=cygwin-patches@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).