From: Jon Turney <jon.turney@dronecode.org.uk>
To: cygwin-patches@cygwin.com
Cc: Jon Turney <jon.turney@dronecode.org.uk>
Subject: [PATCH 0/3] Remove ccwrap
Date: Thu, 15 Oct 2020 15:36:49 +0100 [thread overview]
Message-ID: <20201015143652.56501-1-jon.turney@dronecode.org.uk> (raw)
What does ccwrap actually do?
ccwrap massages the compiler's standard include directories to remove
'/usr/include/w32api', with the intent of allowing it to be overriden by
'--with-windows-headers' (See 4c36016b)
I'm not 100% convinced that this is always working as desired, since in some
places w32api includes are done using <w32api/something.h>, which will find
them via the path /usr/include.
Removing ccwrap simplifies Automake-ification, and also permits 'CXX=ccache
c++', which doesn't work currently in some place.
If this does turn out to be needed, this could also be implemented by
constructing the appropriate compiler flags once, rather than on every compiler
invocation.
For ease of reviewing, this patch series doesn't contain changes to
generated files which would be made by an autoreconf.
Jon Turney (3):
Stop using c++wrap for MinGW-compiled utilities
Remove ccwrap
Remove --with-windows-{libs,headers}
winsup/Makefile.common | 4 +--
winsup/acinclude.m4 | 53 ++++-----------------------------
winsup/c++wrap | 6 ----
winsup/ccwrap | 56 -----------------------------------
winsup/configure.ac | 5 ----
winsup/configure.cygwin | 10 -------
winsup/cygserver/Makefile.in | 9 +-----
winsup/cygserver/configure.ac | 6 ----
winsup/cygwin/Makefile.in | 17 +++--------
winsup/cygwin/configure.ac | 5 ----
winsup/cygwin/gentls_offsets | 2 +-
winsup/utils/Makefile.in | 21 ++-----------
winsup/utils/configure.ac | 3 --
13 files changed, 17 insertions(+), 180 deletions(-)
delete mode 100755 winsup/c++wrap
delete mode 100755 winsup/ccwrap
--
2.28.0
next reply other threads:[~2020-10-15 14:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-15 14:36 Jon Turney [this message]
2020-10-15 14:36 ` [PATCH 1/3] Stop using c++wrap for MinGW-compiled utilities Jon Turney
2020-10-15 14:36 ` [PATCH 2/3] Remove ccwrap Jon Turney
2020-10-27 16:05 ` Jon Turney
2020-10-15 14:36 ` [PATCH 3/3] Remove --with-windows-{libs,headers} Jon Turney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201015143652.56501-1-jon.turney@dronecode.org.uk \
--to=jon.turney@dronecode.org.uk \
--cc=cygwin-patches@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).