From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin-patches@cygwin.com
Subject: Re: [PATCH 00/11] testsuite refurbishment
Date: Fri, 6 Nov 2020 10:44:50 +0100 [thread overview]
Message-ID: <20201106094450.GU33165@calimero.vinschen.de> (raw)
In-Reply-To: <20201105194748.31282-1-jon.turney@dronecode.org.uk>
On Nov 5 19:47, Jon Turney wrote:
> Fix testsuite Makefile/configure, so I have some idea what it's supposed to
> be doing, prior to cleanup and Automake-ification.
>
> > $ make check
> [...]
> > # of expected passes 253
> > # of unexpected failures 23
> > # of unexpected successes 1
> > # of expected failures 7
>
> Future work:
> - Investigate and fix failing tests
> - Tests are re-compiled every time they are run
> - No parallelization of tests
>
> For ease of reviewing, this patch series doesn't contain changes to
> generated files which would be made by an autoreconf.
>
> Jon Turney (11):
> Add testsuite directory to autogen.sh
> Always configure in testsuite subdirectory
> Add rule to testsuite Makefile to regenerate it when needed
> Avoid 'Makefile.in seems to ignore the --datarootdir setting' warning
> Move adding libltp to VPATH after Makefile.common
> Define target_builddir autoconf and Makefile variables
> Detect and use MinGW compilers for testsuite wrappers
> Use absolute path to libltp includes
> Check exit code of a test, rather than stdout
> Set PATH for tests to pick up cygwin0.dll
> Ensure temporary directory used by tests exists
>
> winsup/Makefile.in | 16 +-
> winsup/autogen.sh | 2 +-
> winsup/configure.ac | 2 +-
> winsup/testsuite/Makefile.in | 31 +-
> winsup/testsuite/aclocal.m4 | 831 ------------------------
> winsup/testsuite/autogen.sh | 4 +
> winsup/testsuite/configure.ac | 9 +
> winsup/testsuite/cygrun.c | 5 +-
> winsup/testsuite/winsup.api/cygload.exp | 2 +-
> winsup/testsuite/winsup.api/winsup.exp | 24 +-
> 10 files changed, 60 insertions(+), 866 deletions(-)
> delete mode 100644 winsup/testsuite/aclocal.m4
> create mode 100755 winsup/testsuite/autogen.sh
>
> --
> 2.29.0
Looks good, please push.
Thanks,
Corinna
prev parent reply other threads:[~2020-11-06 9:44 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-05 19:47 Jon Turney
2020-11-05 19:47 ` [PATCH 01/11] Add testsuite directory to autogen.sh Jon Turney
2020-11-05 19:47 ` [PATCH 02/11] Always configure in testsuite subdirectory Jon Turney
2020-11-05 19:47 ` [PATCH 03/11] Add rule to testsuite Makefile to regenerate it when needed Jon Turney
2020-11-05 19:47 ` [PATCH 04/11] Avoid 'Makefile.in seems to ignore the --datarootdir setting' warning Jon Turney
2020-11-05 19:47 ` [PATCH 05/11] Move adding libltp to VPATH after Makefile.common Jon Turney
2020-11-05 19:47 ` [PATCH 06/11] Define target_builddir autoconf and Makefile variables Jon Turney
2020-11-05 19:47 ` [PATCH 07/11] Detect and use MinGW compilers for testsuite wrappers Jon Turney
2020-11-05 19:47 ` [PATCH 08/11] Use absolute path to libltp includes Jon Turney
2020-11-05 19:47 ` [PATCH 09/11] Check exit code of a test, rather than stdout Jon Turney
2020-11-05 19:47 ` [PATCH 10/11] Set PATH for tests to pick up cygwin0.dll Jon Turney
2020-11-05 19:47 ` [PATCH 11/11] Ensure temporary directory used by tests exists Jon Turney
2020-11-08 18:19 ` Ken Brown
2020-11-08 18:52 ` Jon Turney
2020-11-08 19:27 ` Ken Brown
2020-11-08 23:38 ` Brian Inglis
2020-11-09 16:25 ` Jon Turney
2020-11-09 17:48 ` Ken Brown
2020-11-09 21:01 ` Jon Turney
2020-11-06 9:44 ` Corinna Vinschen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201106094450.GU33165@calimero.vinschen.de \
--to=corinna-cygwin@cygwin.com \
--cc=cygwin-patches@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).