From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin-patches@cygwin.com
Subject: Re: [PATCH 2/2] Cygwin: pty: Discard "OSC Ps; ? BEL/ST" in pseudo console output.
Date: Mon, 23 Nov 2020 09:58:59 +0100 [thread overview]
Message-ID: <20201123085859.GN303847@calimero.vinschen.de> (raw)
In-Reply-To: <20201123052815.761-3-takashi.yano@nifty.ne.jp>
Hi Takashi,
just a small style nit:
On Nov 23 14:28, Takashi Yano via Cygwin-patches wrote:
> - If vim is executed in WSL in mintty, some garbage string caused
> by "OSC Ps;? BEL/ST" will be shown in some situations. This patch
> fixes the issue by removing "OSC Ps;? BEL/ST" from pseudo console
> output.
> ---
> winsup/cygwin/fhandler_tty.cc | 30 ++++++++++++++++++++++++++++++
> 1 file changed, 30 insertions(+)
>
> diff --git a/winsup/cygwin/fhandler_tty.cc b/winsup/cygwin/fhandler_tty.cc
> index 911945675..38285c7f4 100644
> --- a/winsup/cygwin/fhandler_tty.cc
> +++ b/winsup/cygwin/fhandler_tty.cc
> @@ -2069,6 +2069,36 @@ fhandler_pty_master::pty_master_fwd_thread ()
> else
> state = 0;
>
> + /* Remove OSC Ps ; ? BEL/ST */
> + for (DWORD i=0; i<rlen; i++)
^^^ ^^^^^^
spaces
Thanks,
Corinna
next prev parent reply other threads:[~2020-11-23 8:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-23 5:28 [PATCH 0/2] Two pty fixes regarding pseudo console Takashi Yano
2020-11-23 5:28 ` [PATCH 1/2] Cygwin: pty: Fix a bug in the code removing "CSI > Pm m" Takashi Yano
2020-11-23 5:28 ` [PATCH 2/2] Cygwin: pty: Discard "OSC Ps; ? BEL/ST" in pseudo console output Takashi Yano
2020-11-23 8:58 ` Corinna Vinschen [this message]
2020-11-23 11:02 ` Takashi Yano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201123085859.GN303847@calimero.vinschen.de \
--to=corinna-cygwin@cygwin.com \
--cc=cygwin-patches@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).