Re: [PATCH 08/11] path.cc: Allow to skip filesystem checks

[Corinna Vinschen <corinna-cygwin@cygwin.com>]

On Jan 15 14:45, Ben Wijen wrote:
> When file attributes are of no concern,
> there is no point to query them.

Without any code setting the flag, this doesn't seem to make any
sense.  At least the commit message should reflect on the reasons
for this change.

> ---
>  winsup/cygwin/path.cc | 3 +++
>  winsup/cygwin/path.h  | 1 +
>  2 files changed, 4 insertions(+)
> 
> diff --git a/winsup/cygwin/path.cc b/winsup/cygwin/path.cc
> index abd3687df..f00707e86 100644
> --- a/winsup/cygwin/path.cc
> +++ b/winsup/cygwin/path.cc
> @@ -931,7 +931,10 @@ path_conv::check (const char *src, unsigned opt,
>  
>      is_fs_via_procsys:
>  
> +	    if (!(opt & PC_SKIP_SYM_CHECK))
> +	    {
>  	      symlen = sym.check (full_path, suff, fs, conv_handle);
> +	    }

Please follow the indentation 4 lines above, and please don't add curly
braces for single line blocks.


Thanks,
Corinna