From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin-patches@cygwin.com
Subject: Re: [PATCH v3] Cygwin: pty: Prevent pty from changing code page of parent console.
Date: Mon, 18 Jan 2021 14:20:19 +0100 [thread overview]
Message-ID: <20210118132019.GF59030@calimero.vinschen.de> (raw)
In-Reply-To: <20210118131057.32-1-takashi.yano@nifty.ne.jp>
On Jan 18 22:10, Takashi Yano via Cygwin-patches wrote:
> - After commit 232fde0e, pty changes console code page when the first
> non-cygwin app is executed. If pty is started in real console device,
> pty changes the code page of root console. This causes very annoying
> result because changing code page changes the font of command prompt
> if console is in legacy mode. This patch avoids this by creating a
> new invisible console for the first pty started in console device.
> ---
> winsup/cygwin/fhandler.h | 5 +-
> winsup/cygwin/fhandler_console.cc | 38 ++++++++--
> winsup/cygwin/fhandler_tty.cc | 118 +++++++++++++++++++++++++++++-
> winsup/cygwin/spawn.cc | 1 +
> winsup/cygwin/tty.cc | 2 +
> winsup/cygwin/tty.h | 2 +
> 6 files changed, 155 insertions(+), 11 deletions(-)
Pushed, including patch 5/5
Thanks,
Corinna
prev parent reply other threads:[~2021-01-18 13:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-18 13:10 Takashi Yano
2021-01-18 13:20 ` Corinna Vinschen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210118132019.GF59030@calimero.vinschen.de \
--to=corinna-cygwin@cygwin.com \
--cc=cygwin-patches@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).