public inbox for cygwin-patches@cygwin.com
 help / color / mirror / Atom feed
From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin-patches@cygwin.com
Subject: Re: [PATCH] Cygwin: normalize_posix_path: fix error handling when .. is encountered
Date: Fri, 22 Jan 2021 10:44:52 +0100	[thread overview]
Message-ID: <20210122094452.GB810271@calimero.vinschen.de> (raw)
In-Reply-To: <20210120154006.53040-1-kbrown@cornell.edu>

On Jan 20 10:40, Ken Brown via Cygwin-patches wrote:
> When .. is in the source path and the path prefix exists but is not a
> directory, return ENOTDIR instead of ENOENT.  This fixes a failing
> gnulib test of realpath(3).
> 
> Addresses: https://lists.gnu.org/archive/html/bug-gnulib/2021-01/msg00214.html
> ---
>  winsup/cygwin/path.cc       | 4 +++-
>  winsup/cygwin/release/3.2.0 | 4 ++++
>  2 files changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/winsup/cygwin/path.cc b/winsup/cygwin/path.cc
> index abd3687df..6dc162806 100644
> --- a/winsup/cygwin/path.cc
> +++ b/winsup/cygwin/path.cc
> @@ -323,8 +323,10 @@ normalize_posix_path (const char *src, char *dst, char *&tail)
>  			  if (!tp.check_usage (4, 3))
>  			    return ELOOP;
>  			  path_conv head (dst, PC_SYM_FOLLOW | PC_POSIX);
> -			  if (!head.isdir())
> +			  if (!head.exists ())
>  			    return ENOENT;
> +			  if (!head.isdir ())
> +			    return ENOTDIR;
>  			  /* At this point, dst is a normalized path.  If the
>  			     normalized path created by path_conv does not
>  			     match the normalized path we're just testing, then
> diff --git a/winsup/cygwin/release/3.2.0 b/winsup/cygwin/release/3.2.0
> index c18a848de..43725cec2 100644
> --- a/winsup/cygwin/release/3.2.0
> +++ b/winsup/cygwin/release/3.2.0
> @@ -48,3 +48,7 @@ Bug Fixes
>  
>  - Fix a bug in fstatat(2) on 32 bit that could cause it to return garbage.
>    Addresses: https://cygwin.com/pipermail/cygwin/2021-January/247399.html
> +
> +- Fix the errno when a path contains .. and the prefix exists but is
> +  not a directory.
> +  Addresses: https://lists.gnu.org/archive/html/bug-gnulib/2021-01/msg00214.html
> -- 
> 2.30.0

Ok, please push.


Thanks,
Corinna

      reply	other threads:[~2021-01-22  9:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-20 15:40 Ken Brown
2021-01-22  9:44 ` Corinna Vinschen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210122094452.GB810271@calimero.vinschen.de \
    --to=corinna-cygwin@cygwin.com \
    --cc=cygwin-patches@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).