public inbox for cygwin-patches@cygwin.com
 help / color / mirror / Atom feed
From: Takashi Yano <takashi.yano@nifty.ne.jp>
To: cygwin-patches@cygwin.com
Subject: [PATCH v7 0/4] Improve pseudo console support.
Date: Thu, 28 Jan 2021 12:26:10 +0900	[thread overview]
Message-ID: <20210128032614.1678-1-takashi.yano@nifty.ne.jp> (raw)

The new implementation of pseudo console support by commit bb428520
provides the important advantages, while there also has been several
disadvantages compared to the previous implementation.

These patches overturn some of them.

The disadvantage:
 1) The cygwin program which calls console API directly does not work.
is supposed to be able to be overcome as well, however, I am not sure
it is worth enough. This will need a lot of hooks for console APIs.
 --> Respecting Corinna's opinion, we decided not to implement this.

v3: Fix typeahead input issue in GDB. Several other bugs have also
    been fixed.
v4: Change the conditions for calling transfer_input() slightly in
    reset_switch_to_pcon() to avoid calling it if uncecessary or
    with no effect.
v5: Small bug fix in v4.
v6: Yet another bug fix.
    Add missing CloseHandle().
    Take into account when the master is running as a service (such
    as ssh session).
v7: Specify FILE_FLAG_OVERLAPPED for to_slave pipe to prevent
    PeekNamedPipe() from blocking in transfer_input().
    Simplify the code determining if the slave is reading.

Takashi Yano (4):
  Cygwin: pty: Inherit typeahead data between two input pipes.
  Cygwin: pty: Keep code page between non-cygwin apps.
  Cygwin: pty: Make apps using console APIs be able to debug with gdb.
  Cygwin: pty: Allow multiple apps to enable pseudo console
    simultaneously.

 winsup/cygwin/fhandler.h      |   22 +-
 winsup/cygwin/fhandler_tty.cc | 1123 +++++++++++++++++++++++++++------
 winsup/cygwin/select.cc       |    7 +-
 winsup/cygwin/spawn.cc        |  106 +++-
 winsup/cygwin/tty.cc          |   13 +-
 winsup/cygwin/tty.h           |   21 +-
 6 files changed, 1059 insertions(+), 233 deletions(-)

-- 
2.30.0


             reply	other threads:[~2021-01-28  3:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-28  3:26 Takashi Yano [this message]
2021-01-28  3:26 ` [PATCH v7 1/4] Cygwin: pty: Inherit typeahead data between two input pipes Takashi Yano
2021-01-28  3:26 ` [PATCH v7 2/4] Cygwin: pty: Keep code page between non-cygwin apps Takashi Yano
2021-01-28  3:26 ` [PATCH v7 3/4] Cygwin: pty: Make apps using console APIs be able to debug with gdb Takashi Yano
2021-01-28  3:26 ` [PATCH v7 4/4] Cygwin: pty: Allow multiple apps to enable pseudo console simultaneously Takashi Yano
2021-01-28 10:25 ` [PATCH v7 0/4] Improve pseudo console support Corinna Vinschen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210128032614.1678-1-takashi.yano@nifty.ne.jp \
    --to=takashi.yano@nifty.ne.jp \
    --cc=cygwin-patches@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).