From: Takashi Yano <takashi.yano@nifty.ne.jp>
To: cygwin-patches@cygwin.com
Subject: [PATCH v2 1/2] Cygwin: console: Make read() thread-safe.
Date: Thu, 28 Jan 2021 21:20:09 +0900 [thread overview]
Message-ID: <20210128122010.1424-2-takashi.yano@nifty.ne.jp> (raw)
In-Reply-To: <20210128122010.1424-1-takashi.yano@nifty.ne.jp>
- Currently read() is somehow not thread-safe. This patch fixes the
issue.
---
winsup/cygwin/fhandler_console.cc | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/winsup/cygwin/fhandler_console.cc b/winsup/cygwin/fhandler_console.cc
index 02d0ac052..d0e5bb33a 100644
--- a/winsup/cygwin/fhandler_console.cc
+++ b/winsup/cygwin/fhandler_console.cc
@@ -530,12 +530,14 @@ fhandler_console::read (void *pv, size_t& buflen)
if (wincap.has_con_24bit_colors ())
request_xterm_mode_input (true, &handle_set);
+ acquire_input_mutex (INFINITE);
while (!input_ready && !get_cons_readahead_valid ())
{
int bgres;
if ((bgres = bg_check (SIGTTIN)) <= bg_eof)
{
buflen = bgres;
+ release_input_mutex ();
return;
}
@@ -552,6 +554,7 @@ wait_retry:
pthread::static_cancel_self ();
/*NOTREACHED*/
case WAIT_TIMEOUT:
+ release_input_mutex ();
set_sig_errno (EAGAIN);
buflen = (size_t) -1;
return;
@@ -572,9 +575,7 @@ wait_retry:
int ret;
acquire_attach_mutex (INFINITE);
- acquire_input_mutex (INFINITE);
ret = process_input_message ();
- release_input_mutex ();
release_attach_mutex ();
switch (ret)
{
@@ -595,7 +596,6 @@ wait_retry:
}
/* Check console read-ahead buffer filled from terminal requests */
- acquire_input_mutex (INFINITE);
while (con.cons_rapoi && *con.cons_rapoi && buflen)
{
buf[copied_chars++] = *con.cons_rapoi++;
@@ -615,11 +615,13 @@ wait_retry:
return;
err:
+ release_input_mutex ();
__seterrno ();
buflen = (size_t) -1;
return;
sig_exit:
+ release_input_mutex ();
set_sig_errno (EINTR);
buflen = (size_t) -1;
}
@@ -984,9 +986,7 @@ fhandler_console::process_input_message (void)
if (toadd)
{
ssize_t ret;
- release_input_mutex ();
line_edit_status res = line_edit (toadd, nread, *ti, &ret);
- acquire_input_mutex (INFINITE);
if (res == line_edit_signalled)
{
stat = input_signalled;
--
2.30.0
next prev parent reply other threads:[~2021-01-28 12:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-28 12:20 [PATCH v2 0/2] Make terminal " Takashi Yano
2021-01-28 12:20 ` Takashi Yano [this message]
2021-01-28 12:24 ` [PATCH v2 1/2] Cygwin: console: Make " Takashi Yano
2021-01-28 12:20 ` [PATCH v2 2/2] Cygwin: pty: Make slave " Takashi Yano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210128122010.1424-2-takashi.yano@nifty.ne.jp \
--to=takashi.yano@nifty.ne.jp \
--cc=cygwin-patches@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).