public inbox for
 help / color / mirror / Atom feed
From: Takashi Yano <>
Subject: [PATCH] Cygwin: console: Align the behaviour against signal with pty.
Date: Fri, 29 Jan 2021 12:45:44 +0900	[thread overview]
Message-ID: <> (raw)

- Currently, read() returns -1 with EINTR if the process is suspended
  by Ctrl-Z and resumed by fg command, while pty continues to read.
  For example, xxd command stops with error "Interrupted system call"
  after Ctrl-Z and fg. This patch aligns the behaviour with pty (and
 winsup/cygwin/ | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/winsup/cygwin/ b/winsup/cygwin/
index 0b404411e..3c0783575 100644
--- a/winsup/cygwin/
+++ b/winsup/cygwin/
@@ -587,7 +587,8 @@ wait_retry:
 	case input_signalled: /* signalled */
 	  release_input_mutex ();
-	  goto sig_exit;
+	  /* The signal will be handled by cygwait() above. */
+	  continue;
 	case input_winch:
 	  release_input_mutex ();

             reply	other threads:[~2021-01-29  3:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-29  3:45 Takashi Yano [this message]
2021-02-01 10:02 ` Corinna Vinschen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).