From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin-patches@cygwin.com
Subject: Re: [PATCH] Cygwin: getdtablesize: always return OPEN_MAX_MAX
Date: Mon, 1 Feb 2021 10:42:19 +0100 [thread overview]
Message-ID: <20210201094219.GE375565@calimero.vinschen.de> (raw)
In-Reply-To: <36a6753f-9aaa-f2ce-f71f-40385b3214c3@cornell.edu>
On Jan 29 14:23, Ken Brown via Cygwin-patches wrote:
> On 1/28/2021 5:28 PM, Ken Brown via Cygwin-patches wrote:
> > > ...ideally by adding a file include/cygwin/limits.h included by
> > > include/limits.h, which defines __OPEN_MAX et al, as required.
> >
> > I'm not completely sure I follow. Do you mean include/cygwin/limits.h
> > should contain
> >
> > #define __OPEN_MAX 3200
> >
> > and include/limits.h should contain
> >
> > #define OPEN_MAX __OPEN_MAX ?
> >
> > For the sake of my education, could you explain the reason for this?
>
> Trying to answer my own question, I guess the idea is to hide implementation
> details from viewers of limits.h. Is that right?
Yes, that was the idea, kind of like a poor mans include/bits dir on
Linux...
> I took a stab at this and
> am about to send a patchset. I'm not sure whether I made a reasonable
> choice of "et al" in "__OPEN_MAX et al".
Sorry, I didn't mean to imply you will have to do that right away.
It was just a thought to move over more values in later patches.
Corinna
next prev parent reply other threads:[~2021-02-01 9:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-28 2:51 Ken Brown
2021-01-28 10:20 ` Corinna Vinschen
2021-01-28 13:42 ` Ken Brown
2021-01-28 16:07 ` Corinna Vinschen
2021-01-28 16:13 ` Corinna Vinschen
2021-01-28 22:28 ` Ken Brown
2021-01-29 19:23 ` Ken Brown
2021-02-01 9:42 ` Corinna Vinschen [this message]
2021-01-28 20:33 ` Ken Brown
2021-02-01 9:50 ` Corinna Vinschen
2021-02-01 10:46 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210201094219.GE375565@calimero.vinschen.de \
--to=corinna-cygwin@cygwin.com \
--cc=cygwin-patches@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).