public inbox for cygwin-patches@cygwin.com
 help / color / mirror / Atom feed
From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin-patches@cygwin.com
Subject: Re: [PATCH] Cygwin: exceptions.cc: Suspend all threads in sig_handle_tty_stop().
Date: Mon, 1 Feb 2021 11:02:07 +0100	[thread overview]
Message-ID: <20210201100207.GJ375565@calimero.vinschen.de> (raw)
In-Reply-To: <20210129034626.157-1-takashi.yano@nifty.ne.jp>

On Jan 29 12:46, Takashi Yano via Cygwin-patches wrote:
> - Currently, thread created by pthread_create() is not suspended by
>   the signal SIGTSTP. For example, even if a process with a thread
>   is suspended by Ctrl-Z, the thread continues running. This patch
>   fixes the issue.
> ---
>  winsup/cygwin/exceptions.cc | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/winsup/cygwin/exceptions.cc b/winsup/cygwin/exceptions.cc
> index c98b92d30..3a6823325 100644
> --- a/winsup/cygwin/exceptions.cc
> +++ b/winsup/cygwin/exceptions.cc
> @@ -902,7 +902,9 @@ sig_handle_tty_stop (int sig, siginfo_t *, void *)
>  	 thread. */
>        /* Use special cygwait parameter to handle SIGCONT.  _main_tls.sig will
>  	 be cleared under lock when SIGCONT is detected.  */
> +      pthread::suspend_all_except_self ();
>        DWORD res = cygwait (NULL, cw_infinite, cw_sig_cont);
> +      pthread::resume_all ();
>        switch (res)
>  	{
>  	case WAIT_SIGNALED:
> -- 
> 2.30.0

Pushed.

Thanks,
Corinna

      reply	other threads:[~2021-02-01 10:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-29  3:46 Takashi Yano
2021-02-01 10:02 ` Corinna Vinschen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210201100207.GJ375565@calimero.vinschen.de \
    --to=corinna-cygwin@cygwin.com \
    --cc=cygwin-patches@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).