From: Takashi Yano <takashi.yano@nifty.ne.jp>
To: cygwin-patches@cygwin.com
Subject: Re: [PATCH] Cygwin: pty: Reduce unecessary input transfer.
Date: Wed, 10 Feb 2021 21:30:24 +0900 [thread overview]
Message-ID: <20210210213024.975a7e82dd9e03d65a164da6@nifty.ne.jp> (raw)
In-Reply-To: <20210210090259.25996-1-takashi.yano@nifty.ne.jp>
On Wed, 10 Feb 2021 18:02:59 +0900
Takashi Yano wrote:
> - Currently, input transfer is performed every time one line is read(),
> if the non-cygwin app is running in the background. With this patch,
> transfer is triggered by setpgid() rather than read() so that the
> unnecessary input transfer can be reduced much in that situation.
> ---
> winsup/cygwin/fhandler.h | 15 +-
> winsup/cygwin/fhandler_tty.cc | 371 ++++++++++++++++++++--------------
> winsup/cygwin/spawn.cc | 76 ++++---
> winsup/cygwin/tty.cc | 89 ++++++++
> winsup/cygwin/tty.h | 16 +-
> 5 files changed, 371 insertions(+), 196 deletions(-)
Hmm. This patch seems to have some race issues.
Please wait for v2 patch.
--
Takashi Yano <takashi.yano@nifty.ne.jp>
prev parent reply other threads:[~2021-02-10 12:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-10 9:02 Takashi Yano
2021-02-10 12:30 ` Takashi Yano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210210213024.975a7e82dd9e03d65a164da6@nifty.ne.jp \
--to=takashi.yano@nifty.ne.jp \
--cc=cygwin-patches@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).