From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from m0.truegem.net (m0.truegem.net [69.55.228.47]) by sourceware.org (Postfix) with ESMTPS id 5182F3850430 for ; Thu, 11 Feb 2021 06:53:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 5182F3850430 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=maxrnd.com Authentication-Results: sourceware.org; spf=none smtp.mailfrom=mark@maxrnd.com Received: (from daemon@localhost) by m0.truegem.net (8.12.11/8.12.11) id 11B6rQS2064361; Wed, 10 Feb 2021 22:53:26 -0800 (PST) (envelope-from mark@maxrnd.com) Received: from 162-235-43-67.lightspeed.irvnca.sbcglobal.net(162.235.43.67), claiming to be "localhost.localdomain" via SMTP by m0.truegem.net, id smtpdhSflXA; Wed Feb 10 22:53:17 2021 From: Mark Geisert To: cygwin-patches@cygwin.com Subject: [PATCH v2] Cygwin: Have tmpfile(3) use O_TMPFILE Date: Wed, 10 Feb 2021 22:53:05 -0800 Message-Id: <20210211065306.457-1-mark@maxrnd.com> X-Mailer: git-send-email 2.30.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-10.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: cygwin-patches@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin core component patch submission and discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Feb 2021 06:53:29 -0000 Per discussion on cygwin-developers, a Cygwin tmpfile(3) implementation has been added to syscalls.cc. This overrides the one supplied by newlib. Then the open(2) flag O_TMPFILE was added to the open call that tmpfile internally makes. This v2 patch removes O_CREAT from open() call as O_TMPFILE obviates it. Note that open() takes a directory's path but returns an fd to a file. --- winsup/cygwin/release/3.2.0 | 4 ++++ winsup/cygwin/syscalls.cc | 17 +++++++++++++++++ 2 files changed, 21 insertions(+) diff --git a/winsup/cygwin/release/3.2.0 b/winsup/cygwin/release/3.2.0 index f748a9bc8..d02d16863 100644 --- a/winsup/cygwin/release/3.2.0 +++ b/winsup/cygwin/release/3.2.0 @@ -19,6 +19,10 @@ What changed: - A few FAQ updates. +- Have tmpfile(3) make use of Win32 FILE_ATTRIBUTE_TEMPORARY via open(2) + flag O_TMPFILE. + Addresses: https://cygwin.com/pipermail/cygwin/2021-January/247304.html + Bug Fixes --------- diff --git a/winsup/cygwin/syscalls.cc b/winsup/cygwin/syscalls.cc index 52a020f07..4cda69033 100644 --- a/winsup/cygwin/syscalls.cc +++ b/winsup/cygwin/syscalls.cc @@ -5225,3 +5225,20 @@ pipe2 (int filedes[2], int mode) syscall_printf ("%R = pipe2([%d, %d], %y)", res, read, write, mode); return res; } + +extern "C" FILE * +tmpfile (void) +{ + char *dir = getenv ("TMPDIR"); + if (!dir) + dir = P_tmpdir; + int fd = open (dir, O_RDWR | O_BINARY | O_TMPFILE, S_IRUSR | S_IWUSR); + if (fd < 0) + return NULL; + FILE *fp = fdopen (fd, "wb+"); + int e = errno; + if (!fp) + close (fd); // ..will remove tmp file + set_errno (e); + return fp; +} -- 2.30.0