public inbox for cygwin-patches@cygwin.com
 help / color / mirror / Atom feed
From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin-patches@cygwin.com
Cc: Jon TURNEY <jon.turney@dronecode.org.uk>
Subject: Re: [PATCH] winsup/doc/posix.xml: add note for getrlimit, setrlimit,  links to notes
Date: Mon, 15 Feb 2021 11:43:50 +0100	[thread overview]
Message-ID: <20210215104350.GK4251@calimero.vinschen.de> (raw)
In-Reply-To: <20210213010600.30473-1-Brian.Inglis@SystematicSW.ab.ca>

Hi Brian,

On Feb 12 18:06, Brian Inglis wrote:
> 
> change notes to see "Implementation Notes" to links to std-notes.html;
> links work in html docs but appear as text in info docs;
> add link to std-notes.html to getrlimit, setrlimit;
> add note to document limitations of getrlimit, setrlimit resources support
> ---
>  winsup/doc/posix.xml | 101 ++++++++++++++++++++++++-------------------
>  1 file changed, 57 insertions(+), 44 deletions(-)
> 

Thanks for the patch, but...

> diff --git a/winsup/doc/posix.xml b/winsup/doc/posix.xml
> index 0669d07de890..71f0373940a5 100644
> --- a/winsup/doc/posix.xml
> +++ b/winsup/doc/posix.xml
> @@ -64,7 +64,7 @@ also IEEE Std 1003.1-2008 (POSIX.1-2008).</para>
>      atoi
>      atol
>      atoll
> -    basename			(see chapter "Implementation Notes")
> +    basename			<ulink url="std-notes.html">(see chapter "Implementation Notes")</ulink>

...please use xref rather than ulink for cross refs within the same
documentation,  i.e.

  (see <xref linkend="std-notes">chapter "Implementation Notes"</xref>)

Unfortunately I just noticed in both cases, that a matching link is
missing in cygwin-api.info afterwards.  However, cross referencing works
in cygwin-ug-net.info, afaics.

Jon, any idea why this is?  I don't see any difference in how the info
files are created.


Thanks,
Corinna

      reply	other threads:[~2021-02-15 10:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-13  1:06 Brian Inglis
2021-02-15 10:43 ` Corinna Vinschen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210215104350.GK4251@calimero.vinschen.de \
    --to=corinna-cygwin@cygwin.com \
    --cc=cygwin-patches@cygwin.com \
    --cc=jon.turney@dronecode.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).