From: Takashi Yano <takashi.yano@nifty.ne.jp>
To: cygwin-patches@cygwin.com
Subject: [PATCH 1/2] Cygwin: console: Fix SIGWINCH handling in Win7.
Date: Thu, 18 Feb 2021 18:01:27 +0900 [thread overview]
Message-ID: <20210218090128.1459-2-takashi.yano@nifty.ne.jp> (raw)
In-Reply-To: <20210218090128.1459-1-takashi.yano@nifty.ne.jp>
- If ENABLE_VIRTUAL_TERMINAL_INPUT is not set, changing window height
does not generate WINDOW_BUFFER_SIZE_EVENT. This happens if console
is in the legacy mode. Therefore, with this patch, the windows size
is checked every time in cons_master_thread() if the cosole is in
the legacy mode.
---
winsup/cygwin/fhandler_console.cc | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/winsup/cygwin/fhandler_console.cc b/winsup/cygwin/fhandler_console.cc
index 5053cb053..4dee506dd 100644
--- a/winsup/cygwin/fhandler_console.cc
+++ b/winsup/cygwin/fhandler_console.cc
@@ -223,6 +223,21 @@ fhandler_console::cons_master_thread (handle_set_t *p, tty *ttyp)
ReleaseMutex (p->input_mutex);
return;
}
+ /* If ENABLE_VIRTUAL_TERMINAL_INPUT is not set, changing
+ window height does not generate WINDOW_BUFFER_SIZE_EVENT.
+ Therefore, check windows size every time here. */
+ if (!wincap.has_con_24bit_colors () || con_is_legacy)
+ {
+ SHORT y = con.dwWinSize.Y;
+ SHORT x = con.dwWinSize.X;
+ con.fillin (p->output_handle);
+ if (y != con.dwWinSize.Y || x != con.dwWinSize.X)
+ {
+ con.scroll_region.Top = 0;
+ con.scroll_region.Bottom = -1;
+ ttyp->kill_pgrp (SIGWINCH);
+ }
+ }
for (i = 0; i < total_read; i++)
{
const char c = input_rec[i].Event.KeyEvent.uChar.AsciiChar;
--
2.30.0
next prev parent reply other threads:[~2021-02-18 9:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-18 9:01 [PATCH 0/2] Console fixes for Win7 Takashi Yano
2021-02-18 9:01 ` Takashi Yano [this message]
2021-02-18 9:01 ` [PATCH 2/2] Cygwin: console: Fix handling of Ctrl-S in Win7 Takashi Yano
2021-02-19 16:58 ` [PATCH 0/2] Console fixes for Win7 Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210218090128.1459-2-takashi.yano@nifty.ne.jp \
--to=takashi.yano@nifty.ne.jp \
--cc=cygwin-patches@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).