* [PATCH v3] Cygwin: clipboard: Fix a bug in read().
@ 2021-12-07 14:35 Takashi Yano
0 siblings, 0 replies; only message in thread
From: Takashi Yano @ 2021-12-07 14:35 UTC (permalink / raw)
To: cygwin-patches
- Fix a bug in fhandler_dev_clipboard::read() that the second read
fails with 'Bad address'.
Addresses:
https://cygwin.com/pipermail/cygwin/2021-December/250141.html
---
winsup/cygwin/fhandler_clipboard.cc | 2 +-
winsup/cygwin/release/3.3.4 | 6 ++++++
2 files changed, 7 insertions(+), 1 deletion(-)
create mode 100644 winsup/cygwin/release/3.3.4
diff --git a/winsup/cygwin/fhandler_clipboard.cc b/winsup/cygwin/fhandler_clipboard.cc
index 0b87dd352..05f54ffb3 100644
--- a/winsup/cygwin/fhandler_clipboard.cc
+++ b/winsup/cygwin/fhandler_clipboard.cc
@@ -229,7 +229,7 @@ fhandler_dev_clipboard::read (void *ptr, size_t& len)
if (pos < (off_t) clipbuf->cb_size)
{
ret = (len > (clipbuf->cb_size - pos)) ? clipbuf->cb_size - pos : len;
- memcpy (ptr, &clipbuf[1] + pos , ret);
+ memcpy (ptr, (char *) (clipbuf + 1) + pos, ret);
pos += ret;
}
}
diff --git a/winsup/cygwin/release/3.3.4 b/winsup/cygwin/release/3.3.4
new file mode 100644
index 000000000..f1c32a1a5
--- /dev/null
+++ b/winsup/cygwin/release/3.3.4
@@ -0,0 +1,6 @@
+Bug Fixes
+---------
+
+- Fix a bug in fhandler_dev_clipboard::read() that the second read
+ fails with 'Bad address'.
+ Addresses: https://cygwin.com/pipermail/cygwin/2021-December/250141.html
--
2.34.1
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-12-07 14:36 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-07 14:35 [PATCH v3] Cygwin: clipboard: Fix a bug in read() Takashi Yano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).