From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from conuserg-11.nifty.com (conuserg-11.nifty.com [210.131.2.78]) by sourceware.org (Postfix) with ESMTPS id 4B4BA3858D28 for ; Tue, 7 Dec 2021 14:36:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4B4BA3858D28 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=nifty.ne.jp Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=nifty.ne.jp Received: from localhost.localdomain (z221123.dynamic.ppp.asahi-net.or.jp [110.4.221.123]) (authenticated) by conuserg-11.nifty.com with ESMTP id 1B7EZOel010406; Tue, 7 Dec 2021 23:35:30 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-11.nifty.com 1B7EZOel010406 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.ne.jp; s=dec2015msa; t=1638887730; bh=5+xzu8VwVsEGeGu2j8NGompKfKXYCNAB7kaTUiwq1TE=; h=From:To:Cc:Subject:Date:From; b=vpyOBhoOvwo67PCCv+0tvuwjaTJUCgTUe0yl7qmrwO20cc+RMS3tlvNuIY1Qsv48L nGwd+URuCirbLwB7L13IbPIu1VCUM0PhJEHcrTgjRinRD5Aogl1M8NwtWEhsYsYYa7 2wlYGksJbRQP3pdK121aQouyizlykCaT5oqzj47nCwqGEPEo9BlbWwd1kBgs8bWc+9 7w1MuWIUG3xntwjdPAzN9m0mv1C3g6NznQ1udn9OOBtDkTMXohlIEuOpQZUMDWnD28 JdhzJhCV6O+28t10/F4Pz1SAdiDWzXcMvYVIN1jXvf/XpVyuvKIUJnOd24W+lqSlre g0+NpeFpUWpBg== X-Nifty-SrcIP: [110.4.221.123] From: Takashi Yano To: cygwin-patches@cygwin.com Subject: [PATCH v3] Cygwin: clipboard: Fix a bug in read(). Date: Tue, 7 Dec 2021 23:35:16 +0900 Message-Id: <20211207143516.1378-1-takashi.yano@nifty.ne.jp> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-10.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: cygwin-patches@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin core component patch submission and discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Dec 2021 14:36:11 -0000 - Fix a bug in fhandler_dev_clipboard::read() that the second read fails with 'Bad address'. Addresses: https://cygwin.com/pipermail/cygwin/2021-December/250141.html --- winsup/cygwin/fhandler_clipboard.cc | 2 +- winsup/cygwin/release/3.3.4 | 6 ++++++ 2 files changed, 7 insertions(+), 1 deletion(-) create mode 100644 winsup/cygwin/release/3.3.4 diff --git a/winsup/cygwin/fhandler_clipboard.cc b/winsup/cygwin/fhandler_clipboard.cc index 0b87dd352..05f54ffb3 100644 --- a/winsup/cygwin/fhandler_clipboard.cc +++ b/winsup/cygwin/fhandler_clipboard.cc @@ -229,7 +229,7 @@ fhandler_dev_clipboard::read (void *ptr, size_t& len) if (pos < (off_t) clipbuf->cb_size) { ret = (len > (clipbuf->cb_size - pos)) ? clipbuf->cb_size - pos : len; - memcpy (ptr, &clipbuf[1] + pos , ret); + memcpy (ptr, (char *) (clipbuf + 1) + pos, ret); pos += ret; } } diff --git a/winsup/cygwin/release/3.3.4 b/winsup/cygwin/release/3.3.4 new file mode 100644 index 000000000..f1c32a1a5 --- /dev/null +++ b/winsup/cygwin/release/3.3.4 @@ -0,0 +1,6 @@ +Bug Fixes +--------- + +- Fix a bug in fhandler_dev_clipboard::read() that the second read + fails with 'Bad address'. + Addresses: https://cygwin.com/pipermail/cygwin/2021-December/250141.html -- 2.34.1