From: Takashi Yano <takashi.yano@nifty.ne.jp>
To: cygwin-patches@cygwin.com
Subject: [PATCH] Cygwin: fhandler_base: Fix double free caused when open() fails.
Date: Tue, 18 Jan 2022 08:05:07 +0900 [thread overview]
Message-ID: <20220117230507.387-1-takashi.yano@nifty.ne.jp> (raw)
- When open fails, archetype stored in archetypes[] is not cleared.
This causes double free when next open fail. This patch fixes the
issue.
Addresses:
https://cygwin.com/pipermail/cygwin/2022-January/250518.html
---
winsup/cygwin/fhandler.cc | 4 ++--
winsup/cygwin/release/3.3.4 | 3 +++
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/winsup/cygwin/fhandler.cc b/winsup/cygwin/fhandler.cc
index fc7c0422e..7d427135e 100644
--- a/winsup/cygwin/fhandler.cc
+++ b/winsup/cygwin/fhandler.cc
@@ -440,8 +440,8 @@ fhandler_base::open_with_arch (int flags, mode_t mode)
if (!(res = (archetype && archetype->io_handle)
|| open (flags, mode & 07777)))
{
- if (archetype)
- delete archetype;
+ if (archetype && archetype->usecount == 0)
+ cygheap->fdtab.delete_archetype (archetype);
}
else if (archetype)
{
diff --git a/winsup/cygwin/release/3.3.4 b/winsup/cygwin/release/3.3.4
index 7c37a575c..71f8dc888 100644
--- a/winsup/cygwin/release/3.3.4
+++ b/winsup/cygwin/release/3.3.4
@@ -23,3 +23,6 @@ Bug Fixes
- Fix an "Invalid argument" problem in posix_spawn on i686.
Addresses: https://cygwin.com/pipermail/cygwin/2022-January/250453.html
+
+- Fix double free for archetype, which is caused when open() fails.
+ Addresses: https://cygwin.com/pipermail/cygwin/2022-January/250518.html
--
2.34.1
next reply other threads:[~2022-01-17 23:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-17 23:05 Takashi Yano [this message]
2022-01-18 11:05 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220117230507.387-1-takashi.yano@nifty.ne.jp \
--to=takashi.yano@nifty.ne.jp \
--cc=cygwin-patches@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).