From: Jon Turney <jon.turney@dronecode.org.uk>
To: cygwin-patches@cygwin.com
Cc: Jon Turney <jon.turney@dronecode.org.uk>
Subject: [PATCH 1/2] Cygwin: Drop pointless loadlib.h includes in utilities
Date: Sat, 26 Feb 2022 16:40:53 +0000 [thread overview]
Message-ID: <20220226164054.26698-2-jon.turney@dronecode.org.uk> (raw)
In-Reply-To: <20220226164054.26698-1-jon.turney@dronecode.org.uk>
These utilities used to LoadLibrary()/GetProcAddress(), but don't
anymore.
---
winsup/utils/cygpath.cc | 1 -
winsup/utils/module_info.cc | 1 -
winsup/utils/path.cc | 1 -
winsup/utils/ps.cc | 1 -
4 files changed, 4 deletions(-)
diff --git a/winsup/utils/cygpath.cc b/winsup/utils/cygpath.cc
index 701c34998..9873e7b16 100644
--- a/winsup/utils/cygpath.cc
+++ b/winsup/utils/cygpath.cc
@@ -29,7 +29,6 @@ details. */
#include <ntdll.h>
#include "wide_path.h"
-#include "loadlib.h"
static char *prog_name;
static char *file_arg, *output_arg;
diff --git a/winsup/utils/module_info.cc b/winsup/utils/module_info.cc
index e0bd4b71a..3e2fc28e2 100644
--- a/winsup/utils/module_info.cc
+++ b/winsup/utils/module_info.cc
@@ -12,7 +12,6 @@ details. */
#include <windows.h>
#define PSAPI_VERSION 1
#include <psapi.h>
-#include "loadlib.h"
/* Returns full name of Dll, which is loaded by hProcess at BaseAddress.
Uses psapi.dll. */
diff --git a/winsup/utils/path.cc b/winsup/utils/path.cc
index df0037c15..fe55a646d 100644
--- a/winsup/utils/path.cc
+++ b/winsup/utils/path.cc
@@ -28,7 +28,6 @@ details. */
#ifdef FSTAB_ONLY
#include <sys/cygwin.h>
#endif
-#include "loadlib.h"
#ifndef FSTAB_ONLY
/* Used when treating / and \ as equivalent. */
diff --git a/winsup/utils/ps.cc b/winsup/utils/ps.cc
index b51657535..dbcacbab4 100644
--- a/winsup/utils/ps.cc
+++ b/winsup/utils/ps.cc
@@ -21,7 +21,6 @@ details. */
#include <cygwin/version.h>
#include <ntdef.h>
#include <ntdll.h>
-#include "loadlib.h"
/* Maximum possible path length under NT. There's no official define
for that value. Note that PATH_MAX is only 4K. */
--
2.35.1
next prev parent reply other threads:[~2022-02-26 16:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-26 16:40 [PATCH 0/2] Drop pointless loadlib.h use " Jon Turney
2022-02-26 16:40 ` Jon Turney [this message]
2022-02-26 16:40 ` [PATCH 2/2] Cygwin: Drop use of loadlib.h in regtool Jon Turney
2022-02-28 9:44 ` Corinna Vinschen
2022-02-28 9:39 ` [PATCH 0/2] Drop pointless loadlib.h use in utilities Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220226164054.26698-2-jon.turney@dronecode.org.uk \
--to=jon.turney@dronecode.org.uk \
--cc=cygwin-patches@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).