From: Takashi Yano <takashi.yano@nifty.ne.jp>
To: cygwin-patches@cygwin.com
Subject: Re: [PATCH v4] Cygwin: pipe: Avoid deadlock for non-cygwin writer.
Date: Fri, 1 Apr 2022 17:44:40 +0900 [thread overview]
Message-ID: <20220401174440.37fa2bb79cc64a0c20e4b3ed@nifty.ne.jp> (raw)
In-Reply-To: <20220330091716.f4541fdff98f2b0aa0c1ec2f@nifty.ne.jp>
On Wed, 30 Mar 2022 09:17:16 +0900
Takashi Yano wrote:
> On Tue, 29 Mar 2022 08:21:11 -0700 (PDT)
> Jeremy Drake wrote:
> > This block seems to be inside a loop over handles. Would it make sense to
> > move the `tty_min dummy_tty` through `t->kill_pgrp` lines outside the
> > loop, and set a flag in the loop instead, so the pgrp only needs to be
> > signaled (killed) once rather than for each handle that needs closing?
>
> Thanks for the advice. I will submit v5 patch reflecting your advice.
I revised the patch again a bit so that __SIGNONCYGCHLD will
be sent only if it is really necessary.
--
Takashi Yano <takashi.yano@nifty.ne.jp>
next prev parent reply other threads:[~2022-04-01 8:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-29 9:07 Takashi Yano
2022-03-29 15:21 ` Jeremy Drake
2022-03-30 0:17 ` Takashi Yano
2022-04-01 8:44 ` Takashi Yano [this message]
2022-03-29 15:40 ` Jeremy Drake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220401174440.37fa2bb79cc64a0c20e4b3ed@nifty.ne.jp \
--to=takashi.yano@nifty.ne.jp \
--cc=cygwin-patches@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).