public inbox for
 help / color / mirror / Atom feed
From: Takashi Yano <>
Subject: [PATCH] Cygwin: pty: Fix timing of creating invisible console.
Date: Sun,  8 May 2022 20:04:06 +0900	[thread overview]
Message-ID: <> (raw)

- Previously, invisible console was created in fixup_after_exec().
  However, actually this should be done in fixup_after_fork(). this
  patch fixes the issue.
 winsup/cygwin/ | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/winsup/cygwin/ b/winsup/cygwin/
index bdde1dce6..9ab681d6c 100644
--- a/winsup/cygwin/
+++ b/winsup/cygwin/
@@ -2467,6 +2467,8 @@ fhandler_pty_slave::bg_check (int sig, bool dontsignal)
 fhandler_pty_slave::fixup_after_fork (HANDLE parent)
+  create_invisible_console ();
   // fork_fixup (parent, inuse, "inuse");
   // fhandler_pty_common::fixup_after_fork (parent);
   report_tty_counts (this, "inherited", "");
@@ -2475,8 +2477,6 @@ fhandler_pty_slave::fixup_after_fork (HANDLE parent)
 fhandler_pty_slave::fixup_after_exec ()
-  create_invisible_console ();
   if (!close_on_exec ())
     fixup_after_fork (NULL);	/* No parent handle required. */

                 reply	other threads:[~2022-05-08 11:04 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).