public inbox for cygwin-patches@cygwin.com
 help / color / mirror / Atom feed
* [PATCH] Cygwin: pty: Avoid script command crash in console.
@ 2022-05-09 11:21 Takashi Yano
  0 siblings, 0 replies; only message in thread
From: Takashi Yano @ 2022-05-09 11:21 UTC (permalink / raw)
  To: cygwin-patches

- Previously, script command sometimes crashes by Ctrl-C if it is
  running in console, and non-cygwin app is foreground. This patch
  fixes the issue.
---
 winsup/cygwin/fhandler_tty.cc | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/winsup/cygwin/fhandler_tty.cc b/winsup/cygwin/fhandler_tty.cc
index bb18d139e..9dfc3c495 100644
--- a/winsup/cygwin/fhandler_tty.cc
+++ b/winsup/cygwin/fhandler_tty.cc
@@ -4184,8 +4184,7 @@ fhandler_pty_common::attach_console_temporarily (DWORD target_pid)
     {
       FreeConsole ();
       AttachConsole (target_pid);
-      init_console_handler (::cygheap->ctty
-			    && ::cygheap->ctty->is_console ());
+      init_console_handler (false);
     }
   return console_exists ? resume_pid : (DWORD) -1;
 }
@@ -4200,8 +4199,7 @@ fhandler_pty_common::resume_from_temporarily_attach (DWORD resume_pid)
       if (console_exists)
 	if (!resume_pid || !AttachConsole (resume_pid))
 	  AttachConsole (ATTACH_PARENT_PROCESS);
-      init_console_handler (::cygheap->ctty
-			    && ::cygheap->ctty->is_console ());
+      init_console_handler (false);
     }
   release_attach_mutex ();
 }
-- 
2.36.0


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-05-09 11:22 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-09 11:21 [PATCH] Cygwin: pty: Avoid script command crash in console Takashi Yano

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).