public inbox for cygwin-patches@cygwin.com
 help / color / mirror / Atom feed
* [PATCH 0/6] testsuite: various fixes
@ 2022-08-26 12:59 Jon Turney
  2022-08-26 12:59 ` [PATCH 1/6] Cygwin: testsuite: Don't write coredump in a child which is expected to segfault Jon Turney
                   ` (6 more replies)
  0 siblings, 7 replies; 8+ messages in thread
From: Jon Turney @ 2022-08-26 12:59 UTC (permalink / raw)
  To: cygwin-patches; +Cc: Jon Turney

This are some fixes for the testsuite I wrote back when I was looking at the
automake conversion, which mainly fix x86_64-specific problems in the
testsuite.

Jon Turney (6):
  Cygwin: testsuite: Don't write coredump in a child which is expected
    to segfault
  Cygwin: testsuite: Remove passing tests from XFAIL list
  Cygwin: testsuite: Fix TEST_RETURN for 64-bit
  Cygwin: testsuite: Fix size of write to temporary file to be mmap()ed
  Cygwin: testsuite: In pathconf01 use the temporary directory instead
    of "/tmp"
  Cygwin: testsuite: Add x86_64 code to "dynamically load cygwin" test

 winsup/cygwin/DevDocs/how-cygtls-works.txt   | 25 +++++---------------
 winsup/testsuite/libltp/include/usctest.h    |  6 ++---
 winsup/testsuite/libltp/lib/parse_opts.c     |  2 +-
 winsup/testsuite/winsup.api/cygload.cc       | 22 ++++++++++++++---
 winsup/testsuite/winsup.api/cygload.exp      |  8 ++++++-
 winsup/testsuite/winsup.api/known_bugs.tcl   |  4 ++--
 winsup/testsuite/winsup.api/ltp/mmap02.c     |  2 +-
 winsup/testsuite/winsup.api/ltp/mmap03.c     |  2 +-
 winsup/testsuite/winsup.api/ltp/mmap04.c     |  2 +-
 winsup/testsuite/winsup.api/ltp/mmap05.c     |  3 +--
 winsup/testsuite/winsup.api/ltp/mmap06.c     |  2 +-
 winsup/testsuite/winsup.api/ltp/mmap07.c     |  2 +-
 winsup/testsuite/winsup.api/ltp/pathconf01.c |  8 ++++++-
 winsup/testsuite/winsup.api/resethand.c      |  5 +++-
 14 files changed, 55 insertions(+), 38 deletions(-)

-- 
2.37.2


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH 1/6] Cygwin: testsuite: Don't write coredump in a child which is expected to segfault
  2022-08-26 12:59 [PATCH 0/6] testsuite: various fixes Jon Turney
@ 2022-08-26 12:59 ` Jon Turney
  2022-08-26 12:59 ` [PATCH 2/6] Cygwin: testsuite: Remove passing tests from XFAIL list Jon Turney
                   ` (5 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: Jon Turney @ 2022-08-26 12:59 UTC (permalink / raw)
  To: cygwin-patches; +Cc: Jon Turney

---
 winsup/testsuite/winsup.api/resethand.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/winsup/testsuite/winsup.api/resethand.c b/winsup/testsuite/winsup.api/resethand.c
index 7d58dcd2c..4bd0fa072 100644
--- a/winsup/testsuite/winsup.api/resethand.c
+++ b/winsup/testsuite/winsup.api/resethand.c
@@ -15,6 +15,9 @@ ouch (int sig)
 int
 main (int argc, char **argv)
 {
+  static struct rlimit nocore = { 0,0 };
+  setrlimit(RLIMIT_CORE, &nocore);
+
   static struct sigaction act;
   if (argc == 1)
     act.sa_flags = SA_RESETHAND;
@@ -31,6 +34,6 @@ main (int argc, char **argv)
       exit (0x42);
     }
   status &= ~0x80;	// remove core dump flag
-  printf ("pid %d exited with status %p\n", pid, (void *) status);
+  printf ("pid %d exited with status %x\n", pid, status);
   exit (argc == 1 ? !(status == SIGSEGV) : !(status == SIGTERM));
 }
-- 
2.37.2


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH 2/6] Cygwin: testsuite: Remove passing tests from XFAIL list
  2022-08-26 12:59 [PATCH 0/6] testsuite: various fixes Jon Turney
  2022-08-26 12:59 ` [PATCH 1/6] Cygwin: testsuite: Don't write coredump in a child which is expected to segfault Jon Turney
@ 2022-08-26 12:59 ` Jon Turney
  2022-08-26 12:59 ` [PATCH 3/6] Cygwin: testsuite: Fix TEST_RETURN for 64-bit Jon Turney
                   ` (4 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: Jon Turney @ 2022-08-26 12:59 UTC (permalink / raw)
  To: cygwin-patches; +Cc: Jon Turney

Remove ltp/fcntl05.c from XFAIL list, since it now PASSes.
Remove ltp/dup03.c from XFAIL list, since it now PASSes.
---
 winsup/testsuite/winsup.api/known_bugs.tcl | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/winsup/testsuite/winsup.api/known_bugs.tcl b/winsup/testsuite/winsup.api/known_bugs.tcl
index e063ee6bb..4f13c90e0 100644
--- a/winsup/testsuite/winsup.api/known_bugs.tcl
+++ b/winsup/testsuite/winsup.api/known_bugs.tcl
@@ -1,4 +1,4 @@
-set xfail_list [list dup03 \
-    fcntl05 setgroups01 setuid02 \
+set xfail_list [list \
+    setgroups01 setuid02 \
     ulimit01 unlink08 \
     sample-fail sample-miscompile]
-- 
2.37.2


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH 3/6] Cygwin: testsuite: Fix TEST_RETURN for 64-bit
  2022-08-26 12:59 [PATCH 0/6] testsuite: various fixes Jon Turney
  2022-08-26 12:59 ` [PATCH 1/6] Cygwin: testsuite: Don't write coredump in a child which is expected to segfault Jon Turney
  2022-08-26 12:59 ` [PATCH 2/6] Cygwin: testsuite: Remove passing tests from XFAIL list Jon Turney
@ 2022-08-26 12:59 ` Jon Turney
  2022-08-26 12:59 ` [PATCH 4/6] Cygwin: testsuite: Fix size of write to temporary file to be mmap()ed Jon Turney
                   ` (3 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: Jon Turney @ 2022-08-26 12:59 UTC (permalink / raw)
  To: cygwin-patches; +Cc: Jon Turney

The result of a function call won't fit in an int if it's e.g. a pointer.
---
 winsup/testsuite/libltp/include/usctest.h | 6 +++---
 winsup/testsuite/libltp/lib/parse_opts.c  | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/winsup/testsuite/libltp/include/usctest.h b/winsup/testsuite/libltp/include/usctest.h
index 6a095db1c..fef349d04 100644
--- a/winsup/testsuite/libltp/include/usctest.h
+++ b/winsup/testsuite/libltp/include/usctest.h
@@ -159,7 +159,7 @@ struct usc_errno_t {
  **********************************************************************/
 #ifdef  _USC_LIB_
 
-extern int TEST_RETURN;
+extern long TEST_RETURN;
 extern int TEST_ERRNO;
 
 #else
@@ -173,7 +173,7 @@ extern struct usc_errno_t TEST_VALID_ENO[USC_MAX_ERRNO];
  * Globals for returning the return code and errno from the system call
  * test macros.
  ***********************************************************************/
-extern int TEST_RETURN;
+extern long TEST_RETURN;
 extern int TEST_ERRNO;
 
 /***********************************************************************
@@ -210,7 +210,7 @@ extern void STD_opts_help();
  *	SCALL = system call and parameters to execute
  *
  ***********************************************************************/
-#define TEST(SCALL) TEST_RETURN = (unsigned) SCALL;  TEST_ERRNO=errno;
+#define TEST(SCALL) TEST_RETURN = SCALL;  TEST_ERRNO=errno;
 
 /***********************************************************************
  * TEST_VOID: calls a system call
diff --git a/winsup/testsuite/libltp/lib/parse_opts.c b/winsup/testsuite/libltp/lib/parse_opts.c
index 0282a0976..1f41bfdd2 100644
--- a/winsup/testsuite/libltp/lib/parse_opts.c
+++ b/winsup/testsuite/libltp/lib/parse_opts.c
@@ -110,7 +110,7 @@ struct usc_errno_t TEST_VALID_ENO[USC_MAX_ERRNO];
    * Globals for returning the return code and errno from the system call
    * test macros.
    ***********************************************************************/
-int TEST_RETURN;
+long TEST_RETURN;
 int TEST_ERRNO;
 
   /***********************************************************************
-- 
2.37.2


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH 4/6] Cygwin: testsuite: Fix size of write to temporary file to be mmap()ed
  2022-08-26 12:59 [PATCH 0/6] testsuite: various fixes Jon Turney
                   ` (2 preceding siblings ...)
  2022-08-26 12:59 ` [PATCH 3/6] Cygwin: testsuite: Fix TEST_RETURN for 64-bit Jon Turney
@ 2022-08-26 12:59 ` Jon Turney
  2022-08-26 12:59 ` [PATCH 5/6] Cygwin: testsuite: In pathconf01 use the temporary directory instead of "/tmp" Jon Turney
                   ` (2 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: Jon Turney @ 2022-08-26 12:59 UTC (permalink / raw)
  To: cygwin-patches; +Cc: Jon Turney

See ltp commit 91361378
---
 winsup/testsuite/winsup.api/ltp/mmap02.c | 2 +-
 winsup/testsuite/winsup.api/ltp/mmap03.c | 2 +-
 winsup/testsuite/winsup.api/ltp/mmap04.c | 2 +-
 winsup/testsuite/winsup.api/ltp/mmap05.c | 3 +--
 winsup/testsuite/winsup.api/ltp/mmap06.c | 2 +-
 winsup/testsuite/winsup.api/ltp/mmap07.c | 2 +-
 6 files changed, 6 insertions(+), 7 deletions(-)

diff --git a/winsup/testsuite/winsup.api/ltp/mmap02.c b/winsup/testsuite/winsup.api/ltp/mmap02.c
index 33a12738c..b96bdb452 100644
--- a/winsup/testsuite/winsup.api/ltp/mmap02.c
+++ b/winsup/testsuite/winsup.api/ltp/mmap02.c
@@ -225,7 +225,7 @@ setup()
 	}
 
 	/* Write test buffer contents into temporary file */
-	if (write(fildes, tst_buff, sizeof(tst_buff)) < (int)sizeof(tst_buff)) {
+	if (write(fildes, tst_buff, page_sz) < page_sz) {
 		tst_brkm(TFAIL, NULL, "write() on %s Failed, errno=%d : %s",
 			 TEMPFILE, errno, strerror(errno));
 		free(tst_buff);
diff --git a/winsup/testsuite/winsup.api/ltp/mmap03.c b/winsup/testsuite/winsup.api/ltp/mmap03.c
index 9302d335d..fba512c28 100644
--- a/winsup/testsuite/winsup.api/ltp/mmap03.c
+++ b/winsup/testsuite/winsup.api/ltp/mmap03.c
@@ -225,7 +225,7 @@ setup()
 	}
 
 	/* Write test buffer contents into temporary file */
-	if (write(fildes, tst_buff, strlen(tst_buff)) < (int)strlen(tst_buff)) {
+	if (write(fildes, tst_buff, page_sz) < page_sz) {
 		tst_brkm(TFAIL, NULL, "write() on %s Failed, errno=%d : %s",
 			 TEMPFILE, errno, strerror(errno));
 		free(tst_buff);
diff --git a/winsup/testsuite/winsup.api/ltp/mmap04.c b/winsup/testsuite/winsup.api/ltp/mmap04.c
index 64d3a8ebe..dbe25aefd 100644
--- a/winsup/testsuite/winsup.api/ltp/mmap04.c
+++ b/winsup/testsuite/winsup.api/ltp/mmap04.c
@@ -225,7 +225,7 @@ setup()
 	}
 
 	/* Write test buffer contents into temporary file */
-	if (write(fildes, tst_buff, strlen(tst_buff)) < (int)strlen(tst_buff)) {
+	if (write(fildes, tst_buff, page_sz) < page_sz) {
 		tst_brkm(TFAIL, NULL, "write() on %s Failed, errno=%d : %s",
 			 TEMPFILE, errno, strerror(errno));
 		free(tst_buff);
diff --git a/winsup/testsuite/winsup.api/ltp/mmap05.c b/winsup/testsuite/winsup.api/ltp/mmap05.c
index bcdfd0cd8..6e75ee222 100644
--- a/winsup/testsuite/winsup.api/ltp/mmap05.c
+++ b/winsup/testsuite/winsup.api/ltp/mmap05.c
@@ -228,8 +228,7 @@ setup()
 	}
 
 	/* Write test buffer contents into temporary file */
-	if (write(fildes, tst_buff, strlen(tst_buff))
-	    != (int)strlen(tst_buff)) {
+	if (write(fildes, tst_buff, page_sz) != page_sz) {
 		tst_brkm(TFAIL, NULL, "write() on %s Failed, errno=%d : %s",
 			 TEMPFILE, errno, strerror(errno));
 		free(tst_buff);
diff --git a/winsup/testsuite/winsup.api/ltp/mmap06.c b/winsup/testsuite/winsup.api/ltp/mmap06.c
index ec113c077..c099f8c33 100644
--- a/winsup/testsuite/winsup.api/ltp/mmap06.c
+++ b/winsup/testsuite/winsup.api/ltp/mmap06.c
@@ -197,7 +197,7 @@ setup()
 	}
 
 	/* Write test buffer contents into temporary file */
-	if (write(fildes, tst_buff, strlen(tst_buff)) < (int)strlen(tst_buff)) {
+	if (write(fildes, tst_buff, page_sz) < page_sz) {
 		tst_brkm(TFAIL, NULL,
 			 "write() on %s Failed, errno=%d : %s",
 			 TEMPFILE, errno, strerror(errno));
diff --git a/winsup/testsuite/winsup.api/ltp/mmap07.c b/winsup/testsuite/winsup.api/ltp/mmap07.c
index ab989f443..6e3bb5112 100644
--- a/winsup/testsuite/winsup.api/ltp/mmap07.c
+++ b/winsup/testsuite/winsup.api/ltp/mmap07.c
@@ -198,7 +198,7 @@ setup()
 	}
 
 	/* Write test buffer contents into temporary file */
-	if (write(fildes, tst_buff, strlen(tst_buff)) < (int)strlen(tst_buff)) {
+	if (write(fildes, tst_buff, page_sz) < page_sz) {
 		tst_brkm(TFAIL, NULL, "write() on %s Failed, errno=%d : %s",
 			 TEMPFILE, errno, strerror(errno));
 		free(tst_buff);
-- 
2.37.2


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH 5/6] Cygwin: testsuite: In pathconf01 use the temporary directory instead of "/tmp"
  2022-08-26 12:59 [PATCH 0/6] testsuite: various fixes Jon Turney
                   ` (3 preceding siblings ...)
  2022-08-26 12:59 ` [PATCH 4/6] Cygwin: testsuite: Fix size of write to temporary file to be mmap()ed Jon Turney
@ 2022-08-26 12:59 ` Jon Turney
  2022-08-26 12:59 ` [PATCH 6/6] Cygwin: testsuite: Add x86_64 code to "dynamically load cygwin" test Jon Turney
  2022-08-26 16:07 ` [PATCH 0/6] testsuite: various fixes Corinna Vinschen
  6 siblings, 0 replies; 8+ messages in thread
From: Jon Turney @ 2022-08-26 12:59 UTC (permalink / raw)
  To: cygwin-patches; +Cc: Jon Turney

In pathconf01 use the temporary directory, instead of "/tmp" (which may not exist).
---
 winsup/testsuite/winsup.api/ltp/pathconf01.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/winsup/testsuite/winsup.api/ltp/pathconf01.c b/winsup/testsuite/winsup.api/ltp/pathconf01.c
index 466875f21..990e6defe 100644
--- a/winsup/testsuite/winsup.api/ltp/pathconf01.c
+++ b/winsup/testsuite/winsup.api/ltp/pathconf01.c
@@ -117,6 +117,7 @@
 
 extern void setup();
 extern void cleanup();
+extern char *TESTDIR;
 
 
 
@@ -127,7 +128,7 @@ extern int Tst_count;		/* Test Case counter for tst_* routines */
 int exp_enos[]={0, 0};
 
 int i;
-const char *path = "/tmp";
+const char *path;
 
 struct pathconf_args
 {
@@ -157,6 +158,9 @@ main(int ac, char **av)
     if ( (msg=parse_opts(ac, av, (option_t *) NULL, NULL)) != (char *) NULL )
 	tst_brkm(TBROK, cleanup, "OPTION PARSING ERROR - %s", msg);
 
+    tst_tmpdir();
+    path = TESTDIR;
+
     /***************************************************************
      * perform global setup for test
      ***************************************************************/
@@ -208,6 +212,8 @@ main(int ac, char **av)
     /***************************************************************
      * cleanup and exit
      ***************************************************************/
+    tst_rmdir();
+
     cleanup();
 
     return 0;
-- 
2.37.2


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH 6/6] Cygwin: testsuite: Add x86_64 code to "dynamically load cygwin" test
  2022-08-26 12:59 [PATCH 0/6] testsuite: various fixes Jon Turney
                   ` (4 preceding siblings ...)
  2022-08-26 12:59 ` [PATCH 5/6] Cygwin: testsuite: In pathconf01 use the temporary directory instead of "/tmp" Jon Turney
@ 2022-08-26 12:59 ` Jon Turney
  2022-08-26 16:07 ` [PATCH 0/6] testsuite: various fixes Corinna Vinschen
  6 siblings, 0 replies; 8+ messages in thread
From: Jon Turney @ 2022-08-26 12:59 UTC (permalink / raw)
  To: cygwin-patches; +Cc: Jon Turney

This still needs some more voudou to actually work.

Also update how-cygtls-works.txt a bit
---
 winsup/cygwin/DevDocs/how-cygtls-works.txt | 25 ++++++----------------
 winsup/testsuite/winsup.api/cygload.cc     | 22 ++++++++++++++++---
 winsup/testsuite/winsup.api/cygload.exp    |  8 ++++++-
 3 files changed, 32 insertions(+), 23 deletions(-)

diff --git a/winsup/cygwin/DevDocs/how-cygtls-works.txt b/winsup/cygwin/DevDocs/how-cygtls-works.txt
index e4f694118..633c4da96 100644
--- a/winsup/cygwin/DevDocs/how-cygtls-works.txt
+++ b/winsup/cygwin/DevDocs/how-cygtls-works.txt
@@ -4,8 +4,8 @@ All cygwin threads have separate context in an object of class _cygtls.  The
 storage for this object is kept on the stack in the bottom __CYGTLS_PADSIZE__
 bytes.  Each thread references the storage via the Thread Environment Block
 (aka Thread Information Block), which Windows maintains for each user thread
-in the system, with the address in the FS segment register.  The memory
-is laid out as in the NT_TIB structure from <w32api/winnt.h>:
+in the system, with the address in a segment register (FS on x86, GS on x86_64).
+The memory is laid out as in the NT_TIB structure from <w32api/winnt.h>:
 
 typedef struct _NT_TIB {
 	struct _EXCEPTION_REGISTRATION_RECORD *ExceptionList;
@@ -20,16 +20,10 @@ typedef struct _NT_TIB {
 	struct _NT_TIB *Self;
 } NT_TIB,*PNT_TIB;
 
-Cygwin sees it like this:
-
-extern exception_list *_except_list asm ("%fs:0");      // exceptions.cc
-extern char *_tlsbase __asm__ ("%fs:4");                // cygtls.h
-extern char *_tlstop __asm__ ("%fs:8");                 // cygtls.h
-
-And accesses cygtls like this:
-
-#define _my_tls (((_cygtls *) _tlsbase)[-1])            // cygtls.h
+Cygwin accesses cygtls like this (see cygtls.h):
 
+#define _my_tls (*((_cygtls *) ((PBYTE) NtCurrentTeb()->Tib.StackBase \
+		                - __CYGTLS_PADSIZE__)))
 
 Initialization always goes through _cygtls::init_thread().  It works
 in the following ways:
@@ -65,11 +59,4 @@ __CYGTLS_PADSIZE__ bytes down from there are overwritten.
 
 Debugging
 
-You can examine the segment registers in gdb via "info w32 selector $fs"
-(which is using GetThreadSelectorEntry()) to get results like this:
-
-    Selector $fs
-    0x03b: base=0x7ffdd000 limit=0x00000fff 32-bit Data (Read/Write, Exp-up)
-    Priviledge level = 3. Byte granular.
-
-"x/3x 0x7ffdd000" will give you _except_list, _tlsbase, and _tlstop.
+You can examine the TIB in gdb via "info w32 tib"
diff --git a/winsup/testsuite/winsup.api/cygload.cc b/winsup/testsuite/winsup.api/cygload.cc
index faad5ce0e..f5ca8db9a 100644
--- a/winsup/testsuite/winsup.api/cygload.cc
+++ b/winsup/testsuite/winsup.api/cygload.cc
@@ -43,7 +43,10 @@ using std::string;
 cygwin::padding *cygwin::padding::_main = NULL;
 DWORD cygwin::padding::_mainTID = 0;
 
-// A few cygwin constants.
+// Cygwin signal constants
+#undef SIGINT
+#undef SIGTERM
+
 static const int SIGHUP = 1;
 static const int SIGINT = 2;
 static const int SIGTERM = 15;  // Cygwin won't deliver this one to us;
@@ -68,17 +71,30 @@ cygwin::padding::padding ()
 
   _end = _padding + sizeof (_padding);
   char *stackbase;
-#ifdef __GNUC__
+#ifdef __GNUC__ /* GCC */
+# ifdef __x86_64__
+    __asm__ (
+    "mov %%gs:8, %0"
+    :"=r"(stackbase)
+    );
+# elif __X86__
   __asm__ (
     "movl %%fs:4, %0"
     :"=r"(stackbase)
     );
-#else
+# else
+#  error Unknown architecture
+# endif
+#else /* !GCC assumed to be MSVC */
+# ifdef __X86__
   __asm
       {
         mov eax, fs:[4];
         mov stackbase, eax;
       }
+#else
+#  error Unknown architecture
+# endif
 #endif
   _stackbase = stackbase;
 
diff --git a/winsup/testsuite/winsup.api/cygload.exp b/winsup/testsuite/winsup.api/cygload.exp
index e7b439512..8ba8249bb 100644
--- a/winsup/testsuite/winsup.api/cygload.exp
+++ b/winsup/testsuite/winsup.api/cygload.exp
@@ -14,7 +14,13 @@ proc ws_spawn {cmd args} {
     verbose send "catchCode = $rv\n"
 }
 
-ws_spawn "$MINGW_CXX $srcdir/$subdir/cygload.cc -o mingw-cygload.exe -lstdc++ -Wl,-e,_cygloadCRTStartup@0"
+if { [string match "i686" $target_alias] } {
+    set entrypoint "_cygloadCRTStartup@0"
+} else {
+    set entrypoint "cygloadCRTStartup"
+}
+
+ws_spawn "$MINGW_CXX $srcdir/$subdir/cygload.cc -o mingw-cygload.exe -static -Wl,-e,$entrypoint"
 
 if { $rv != {0 {}} } {
     verbose -log "$rv"
-- 
2.37.2


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 0/6] testsuite: various fixes
  2022-08-26 12:59 [PATCH 0/6] testsuite: various fixes Jon Turney
                   ` (5 preceding siblings ...)
  2022-08-26 12:59 ` [PATCH 6/6] Cygwin: testsuite: Add x86_64 code to "dynamically load cygwin" test Jon Turney
@ 2022-08-26 16:07 ` Corinna Vinschen
  6 siblings, 0 replies; 8+ messages in thread
From: Corinna Vinschen @ 2022-08-26 16:07 UTC (permalink / raw)
  To: cygwin-patches

On Aug 26 13:59, Jon Turney wrote:
> This are some fixes for the testsuite I wrote back when I was looking at the
> automake conversion, which mainly fix x86_64-specific problems in the
> testsuite.

LGTM


Corinna

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2022-08-26 16:08 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-26 12:59 [PATCH 0/6] testsuite: various fixes Jon Turney
2022-08-26 12:59 ` [PATCH 1/6] Cygwin: testsuite: Don't write coredump in a child which is expected to segfault Jon Turney
2022-08-26 12:59 ` [PATCH 2/6] Cygwin: testsuite: Remove passing tests from XFAIL list Jon Turney
2022-08-26 12:59 ` [PATCH 3/6] Cygwin: testsuite: Fix TEST_RETURN for 64-bit Jon Turney
2022-08-26 12:59 ` [PATCH 4/6] Cygwin: testsuite: Fix size of write to temporary file to be mmap()ed Jon Turney
2022-08-26 12:59 ` [PATCH 5/6] Cygwin: testsuite: In pathconf01 use the temporary directory instead of "/tmp" Jon Turney
2022-08-26 12:59 ` [PATCH 6/6] Cygwin: testsuite: Add x86_64 code to "dynamically load cygwin" test Jon Turney
2022-08-26 16:07 ` [PATCH 0/6] testsuite: various fixes Corinna Vinschen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).