From: Takashi Yano <takashi.yano@nifty.ne.jp>
To: cygwin-patches@cygwin.com
Subject: Re: [PATCH] Cygwin: fsync: Fix EINVAL for block device.
Date: Sun, 22 Jan 2023 00:22:37 +0900 [thread overview]
Message-ID: <20230122002237.1770130e6ab0b0fadd7189b2@nifty.ne.jp> (raw)
In-Reply-To: <Y8v8cdscNlnXbVxE@calimero.vinschen.de>
On Sat, 21 Jan 2023 15:53:37 +0100
Corinna Vinschen wrote:
> Hi Takashi,
>
> On Jan 21 21:44, Takashi Yano wrote:
> > The commit af8a7c13b516 has a problem that fsync returns EINVAL for
> > block device. This patch treats block devices as a special case.
> > https://cygwin.com/pipermail/cygwin/2023-January/252916.html
> >
> > Fixes: af8a7c13b516 ("Cygwin: fsync: Return EINVAL for special files.")
> > Signed-off-by: Takashi Yano <takashi.yano@nifty.ne.jp>
> > ---
> > winsup/cygwin/fhandler/base.cc | 23 ++++++++++++++++++++++-
> > 1 file changed, 22 insertions(+), 1 deletion(-)
> >
> > diff --git a/winsup/cygwin/fhandler/base.cc b/winsup/cygwin/fhandler/base.cc
> > index b2738cf20..fc0410522 100644
> > --- a/winsup/cygwin/fhandler/base.cc
> > +++ b/winsup/cygwin/fhandler/base.cc
> > @@ -1725,10 +1725,31 @@ fhandler_base::utimens (const struct timespec *tvp)
> > return -1;
> > }
> >
> > +static bool
> > +is_block_device (_major_t major)
> > +{
> > + switch (major)
> > + {
> > + case DEV_FLOPPY_MAJOR:
> > + case DEV_SD_MAJOR:
> > + case DEV_CDROM_MAJOR:
> > + case DEV_SD1_MAJOR:
> > + case DEV_SD2_MAJOR:
> > + case DEV_SD3_MAJOR:
> > + case DEV_SD4_MAJOR:
> > + case DEV_SD5_MAJOR:
> > + case DEV_SD6_MAJOR:
> > + case DEV_SD7_MAJOR:
> > + return true;
> > + }
> > + return false;
> > +}
> > +
>
> You shouldn't need that. Just check S_ISBLK (pc.dev.mode ())
Thanks for the advice. I looked into the S_ISBLK macro and
winsup/cygwin/devices.cc and noticed that S_ISBLK() returns
true for tape device. Is this the right thing?
--
Takashi Yano <takashi.yano@nifty.ne.jp>
next prev parent reply other threads:[~2023-01-21 15:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-21 12:44 Takashi Yano
2023-01-21 14:53 ` Corinna Vinschen
2023-01-21 15:22 ` Takashi Yano [this message]
2023-01-21 17:22 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230122002237.1770130e6ab0b0fadd7189b2@nifty.ne.jp \
--to=takashi.yano@nifty.ne.jp \
--cc=cygwin-patches@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).