From: Takashi Yano <takashi.yano@nifty.ne.jp>
To: cygwin-patches@cygwin.com
Subject: Re: [PATCH] Cygwin: dsp: Implement SNDCTL_DSP_SETFRAGMENT ioctl().
Date: Tue, 31 Jan 2023 20:20:49 +0900 [thread overview]
Message-ID: <20230131202049.d5da058b1865fbe9fda95a8f@nifty.ne.jp> (raw)
In-Reply-To: <Y9jfSM8nB6Z+eT3O@calimero.vinschen.de>
On Tue, 31 Jan 2023 10:28:40 +0100
Corinna Vinschen wrote:
> On Jan 30 22:09, Takashi Yano wrote:
> > Previously, SNDCTL_DSP_SETFRAGMENT was just a fake. In this patch,
> > it has been implemented to allow latency control in some apps.
> >
> > Reviewed-by: Corinna Vinschen <corinna@vinschen.de>
> > Signed-off-by: Takashi Yano <takashi.yano@nifty.ne.jp>
> > ---
> > winsup/cygwin/fhandler/dsp.cc | 78 ++++++++++++-------------
> > winsup/cygwin/local_includes/fhandler.h | 3 +
> > 2 files changed, 42 insertions(+), 39 deletions(-)
>
> LGTM. Given how much I *don't* use the audio stuff in Cygwin,
> would you just like to take over maintainership for this code?
BTW, should this pach be applied only for master branch?
What do you think?
--
Takashi Yano <takashi.yano@nifty.ne.jp>
next prev parent reply other threads:[~2023-01-31 11:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-30 13:09 Takashi Yano
2023-01-31 9:28 ` Corinna Vinschen
2023-01-31 11:18 ` Takashi Yano
2023-01-31 11:30 ` Corinna Vinschen
2023-01-31 11:20 ` Takashi Yano [this message]
2023-01-31 11:31 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230131202049.d5da058b1865fbe9fda95a8f@nifty.ne.jp \
--to=takashi.yano@nifty.ne.jp \
--cc=cygwin-patches@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).