From: Takashi Yano <takashi.yano@nifty.ne.jp>
To: "Lavrentiev, Anton (NIH/NLM/NCBI) [C]" <lavr@ncbi.nlm.nih.gov>
Cc: cygwin-patches@cygwin.com
Subject: Re: [EXTERNAL] [PATCH] Cygwin: ctty: Replace ctty constant with more descriptive macros.
Date: Tue, 7 Mar 2023 12:30:06 +0900 [thread overview]
Message-ID: <20230307123006.17e133d2bc274354f965badb@nifty.ne.jp> (raw)
In-Reply-To: <DM8PR09MB7095179671A47284BE556204A5B79@DM8PR09MB7095.namprd09.prod.outlook.com>
On Tue, 7 Mar 2023 02:42:49 +0000
"Lavrentiev, Anton (NIH/NLM/NCBI) [C]" wrote:
> Can't help but notice that these two lines are not exactly logically equivalent:
> format_process_ctty (void *data, char *&destbuf)
> {
> _pinfo *p = (_pinfo *) data;
> - if (p->ctty < 0)
> + if (!CTTY_IS_VALID (p->ctty))
>
> And here as well:
>
> {
> if (str == NULL)
> str = _my_tls.locals.ttybuf;
> - if (myself->ctty < 0)
> + if (!CTTY_IS_VALID (myself->ctty))
Thanks.
You are right, however, ctty value 0 is never used, so no problem I think.
--
Takashi Yano <takashi.yano@nifty.ne.jp>
prev parent reply other threads:[~2023-03-07 3:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-07 2:33 Takashi Yano
[not found] ` <DM8PR09MB7095179671A47284BE556204A5B79@DM8PR09MB7095.namprd09.prod.outlook.com>
2023-03-07 3:30 ` Takashi Yano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230307123006.17e133d2bc274354f965badb@nifty.ne.jp \
--to=takashi.yano@nifty.ne.jp \
--cc=cygwin-patches@cygwin.com \
--cc=lavr@ncbi.nlm.nih.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).