From: YO4 <ysno@ac.auone-net.jp>
To: cygwin-patches@cygwin.com
Cc: YO4 <ysno@ac.auone-net.jp>
Subject: [PATCH 1/3] fix unlink in container
Date: Fri, 17 Mar 2023 23:43:44 +0900 [thread overview]
Message-ID: <20230317144346.871-2-ysno@ac.auone-net.jp> (raw)
In-Reply-To: <20230317144346.871-1-ysno@ac.auone-net.jp>
Deleting files returns STATUS_INVALID_PARAMETE on a bind mounted file system in hyper-v container with FILE_DISPOSITION_POSIX_SEMANTICS.
Therefore fall back to default method.
This code is suggeted by dscho and I change it more simple.
---
winsup/cygwin/syscalls.cc | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/winsup/cygwin/syscalls.cc b/winsup/cygwin/syscalls.cc
index 5c7f46a99..ac89888ce 100644
--- a/winsup/cygwin/syscalls.cc
+++ b/winsup/cygwin/syscalls.cc
@@ -731,7 +731,10 @@ _unlink_nt (path_conv &pc, bool shareable)
/* Trying to delete in-use executables and DLLs using
FILE_DISPOSITION_POSIX_SEMANTICS returns STATUS_CANNOT_DELETE.
Fall back to the default method. */
- if (status != STATUS_CANNOT_DELETE)
+ /* Additionaly that returns STATUS_INVALID_PARAMETER
+ on a bind mounted fs in hyper-v container. Falling back too. */
+ if (status != STATUS_CANNOT_DELETE
+ && status != STATUS_INVALID_PARAMETER)
goto out;
}
--
2.40.0.windows.1
next prev parent reply other threads:[~2023-03-17 14:44 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-17 14:43 [PATCH 0/3] fix unlink/rename failure in hyper-v container YO4
2023-03-17 14:43 ` YO4 [this message]
2023-03-17 14:43 ` [PATCH 2/3] fix rename in container YO4
2023-03-17 14:43 ` [PATCH 3/3] log disabling posix semantics YO4
2023-03-17 19:15 ` [PATCH 0/3] fix unlink/rename failure in hyper-v container Corinna Vinschen
2023-03-18 5:29 ` Yoshinao Muramatsu
2023-03-18 10:01 ` Corinna Vinschen
2023-03-20 13:06 ` Yoshinao Muramatsu
2023-03-20 14:51 ` Corinna Vinschen
2023-03-20 14:54 ` Corinna Vinschen
2023-03-20 20:37 ` Corinna Vinschen
2023-03-21 15:32 ` Yoshinao Muramatsu
2023-03-21 17:58 ` Corinna Vinschen
2023-03-23 16:40 ` Yoshinao Muramatsu
2023-03-24 11:54 ` Corinna Vinschen
2023-03-24 13:20 ` Jon Turney
2023-03-24 13:22 ` Corinna Vinschen
2023-03-24 14:20 ` Jon Turney
2023-03-24 13:48 ` Yoshinao Muramatsu
2023-03-20 11:50 ` [PATCH 0/3] fix unlink/rename failure in hyper-v container(regenerate) Yoshinao Muramatsu
2023-03-20 11:51 ` [PATCH 1/3] fix unlink in container Yoshinao Muramatsu
2023-03-20 11:51 ` [PATCH 2/3] fix rename " Yoshinao Muramatsu
2023-03-20 11:51 ` [PATCH 3/3] log disabling posix semantics Yoshinao Muramatsu
2023-03-20 12:12 ` [PATCH 0/3] fix unlink/rename failure in hyper-v container(regenerate) Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230317144346.871-2-ysno@ac.auone-net.jp \
--to=ysno@ac.auone-net.jp \
--cc=cygwin-patches@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).