public inbox for cygwin-patches@cygwin.com
 help / color / mirror / Atom feed
From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin-patches@cygwin.com
Cc: Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: [PATCH 0/5] Fix AT_EMPTY_PATH handling
Date: Wed, 12 Jul 2023 14:07:59 +0200	[thread overview]
Message-ID: <20230712120804.2992142-1-corinna-cygwin@cygwin.com> (raw)

From: Corinna Vinschen <corinna@vinschen.de>

The GLIBC extension AT_EMPTY_PATH allows the functions fchownat
and fstatat to operate on dirfd alone, if the given pathname is an
empty string.  This also allows to operate on any file type, not
only directories.

Commit fa84aa4dd2fb4 broke this.  It only allows dirfd to be a
directory in calls to these two functions.

Fix that by handling AT_EMPTY_PATH right in gen_full_path_at.
A valid dirfd and an empty pathname is now a valid combination
and, noticably, this returns a valid path in path_ret.  That
in turn allows to remove the additional path generation code
from the callers.

Fixes: fa84aa4dd2fb ("Cygwin: fix errno values set by readlinkat")
Reported-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Corinna Vinschen <corinna@vinschen.de>

Corinna Vinschen (5):
  Cygwin: gen_full_path_at: drop never reached code
  Define _AT_NULL_PATHNAME_ALLOWED
  Cygwin: use new _AT_NULL_PATHNAME_ALLOWED flag
  Cygwin: Fix and streamline AT_EMPTY_PATH handling
  Cygwin: add AT_EMPTY_PATH fix to release message

 newlib/libc/include/sys/_default_fcntl.h | 11 +++--
 winsup/cygwin/release/3.4.8              |  4 ++
 winsup/cygwin/syscalls.cc                | 61 ++++++------------------
 3 files changed, 25 insertions(+), 51 deletions(-)

-- 
2.40.1


             reply	other threads:[~2023-07-12 12:08 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-12 12:07 Corinna Vinschen [this message]
2023-07-12 12:08 ` [PATCH 1/5] Cygwin: gen_full_path_at: drop never reached code Corinna Vinschen
2023-07-12 12:08 ` [PATCH 2/5] Define _AT_NULL_PATHNAME_ALLOWED Corinna Vinschen
2023-07-12 12:08 ` [PATCH 3/5] Cygwin: use new _AT_NULL_PATHNAME_ALLOWED flag Corinna Vinschen
2023-07-12 12:08 ` [PATCH 4/5] Cygwin: Fix and streamline AT_EMPTY_PATH handling Corinna Vinschen
2023-07-12 12:08 ` [PATCH 5/5] Cygwin: add AT_EMPTY_PATH fix to release message Corinna Vinschen
2023-07-28 16:11   ` Pedro Alves
2023-07-28 19:28     ` Corinna Vinschen
2023-07-24 15:21 ` [PATCH 0/5] Fix AT_EMPTY_PATH handling Corinna Vinschen
2023-07-26  9:10   ` Johannes Schindelin
2023-07-26 13:12     ` Corinna Vinschen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230712120804.2992142-1-corinna-cygwin@cygwin.com \
    --to=corinna-cygwin@cygwin.com \
    --cc=cygwin-patches@cygwin.com \
    --cc=johannes.schindelin@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).