From: Jon Turney <jon.turney@dronecode.org.uk>
To: Cygwin Patches <cygwin-patches@cygwin.com>
Subject: Re: [PATCH] Cygwin: Set threadnames with SetThreadDescription()
Date: Wed, 1 Jun 2022 18:48:25 +0100 [thread overview]
Message-ID: <27cd7dab-733f-f670-71a0-8f5dfc430a7c@dronecode.org.uk> (raw)
In-Reply-To: <b0d41109-f306-f896-03bc-468e87982450@cornell.edu>
On 30/05/2022 16:37, Ken Brown wrote:
> On 5/29/2022 10:03 AM, Jon Turney wrote:
>> gdb master recently learnt how to use GetThreadDescription() [1], so set
>> threadnames using SetThreadDescription() [available since Windows
>> 101607] as well.
>>
>> This is superior to using a special exception to indicate the thread
>> name to the debugger, because the thread name isn't missed if you don't
>> have a debugger attached at the time it's set.
>>
>> It's not clear what the encoding of a thread name string is, we assume
>> UTF8 for the moment.
>>
>> For the moment, continue to use the old method as well, for the benefit
>> of older gdb versions etc.
>
> LGTM, except for a few missing spaces (see below), although maybe you
> did that deliberately since the existing code was already like that.
Nope, that's just me messing up on the coding style conventions.
prev parent reply other threads:[~2022-06-01 17:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-29 14:03 Jon Turney
2022-05-30 15:37 ` Ken Brown
2022-06-01 17:48 ` Jon Turney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27cd7dab-733f-f670-71a0-8f5dfc430a7c@dronecode.org.uk \
--to=jon.turney@dronecode.org.uk \
--cc=cygwin-patches@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).