Rename detached debug info as cygwin1.dll.dbg

Rename detached debug info as cygwin1.dll.dbg

[Jon TURNEY]

[-- Attachment #1: Type: text/plain, Size: 439 bytes --]


Not sure if this is wanted, and it obviously has some knock on effects 
on package and snapshot generation.

But, cygport names detached debug info files by appending the .dbg 
suffix.  This is 'obviously correct' as it means that both a foo.exe and 
foo.dll can exist and have detached debug info.

For consistency, the attached patch changes the name of the detached 
debug info file for cygwin1.dll from cygwin1.dbg to cygwin1.dll.dbg

[-- Attachment #2: consistent_dbg_name.patch --]
[-- Type: text/plain, Size: 729 bytes --]

Index: cygwin/Makefile.in
===================================================================
RCS file: /cvs/src/src/winsup/cygwin/Makefile.in,v
retrieving revision 1.272
diff -u -u -p -r1.272 Makefile.in
--- cygwin/Makefile.in	9 Feb 2014 19:44:54 -0000	1.272
+++ cygwin/Makefile.in	23 May 2014 13:28:15 -0000
@@ -437,7 +437,7 @@ $(TEST_DLL_NAME): $(LDSCRIPT) dllfixdbg 
 	-e $(DLL_ENTRY) $(DEF_FILE) $(DLL_OFILES) version.o winver.o \
 	$(MALLOC_OBJ) $(LIBSERVER) $(LIBM) $(LIBC) \
 	-lgcc $(DLL_IMPORTS) -Wl,-Map,cygwin.map
-	@$(word 2,$^) $(OBJDUMP) $(OBJCOPY) $@ ${patsubst %0.dll,%1.dbg,$@}
+	@$(word 2,$^) $(OBJDUMP) $(OBJCOPY) $@ ${patsubst %0.dll,%1.dll.dbg,$@}
 	@ln -f $@ new-$(DLL_NAME)
 
 # Rule to build libcygwin.a

Re: Rename detached debug info as cygwin1.dll.dbg

[Corinna Vinschen]

[-- Attachment #1: Type: text/plain, Size: 877 bytes --]

On May 23 14:40, Jon TURNEY wrote:
> 
> Not sure if this is wanted, and it obviously has some knock on effects on
> package and snapshot generation.
> 
> But, cygport names detached debug info files by appending the .dbg suffix.
> This is 'obviously correct' as it means that both a foo.exe and foo.dll can
> exist and have detached debug info.
> 
> For consistency, the attached patch changes the name of the detached debug
> info file for cygwin1.dll from cygwin1.dbg to cygwin1.dll.dbg

As far as releases go, this is ok.  I'll just have to tweak the next
cygport file slightly.

Chris might have to tweak the snapshot generation script as well, so
he probably wants to chime in, too.


Thanks,
Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]

Re: Rename detached debug info as cygwin1.dll.dbg

[Christopher Faylor]

On Fri, May 23, 2014 at 04:05:34PM +0200, Corinna Vinschen wrote:
>On May 23 14:40, Jon TURNEY wrote:
>> 
>> Not sure if this is wanted, and it obviously has some knock on effects on
>> package and snapshot generation.
>> 
>> But, cygport names detached debug info files by appending the .dbg suffix.
>> This is 'obviously correct' as it means that both a foo.exe and foo.dll can
>> exist and have detached debug info.
>> 
>> For consistency, the attached patch changes the name of the detached debug
>> info file for cygwin1.dll from cygwin1.dbg to cygwin1.dll.dbg
>
>As far as releases go, this is ok.  I'll just have to tweak the next
>cygport file slightly.
>
>Chris might have to tweak the snapshot generation script as well, so
>he probably wants to chime in, too.

It's more than just a tweak.  I've known that there is a discrepancy for
a long time but haven't considered it that big a deal.  I'd prefer that
this change not be made.

Re: Rename detached debug info as cygwin1.dll.dbg

[Jon TURNEY]

On 25/05/2014 04:53, Christopher Faylor wrote:
> On Fri, May 23, 2014 at 04:05:34PM +0200, Corinna Vinschen wrote:
>> On May 23 14:40, Jon TURNEY wrote:
>>>
>>> Not sure if this is wanted, and it obviously has some knock on effects on
>>> package and snapshot generation.
>>>
>>> But, cygport names detached debug info files by appending the .dbg suffix.
>>> This is 'obviously correct' as it means that both a foo.exe and foo.dll can
>>> exist and have detached debug info.
>>>
>>> For consistency, the attached patch changes the name of the detached debug
>>> info file for cygwin1.dll from cygwin1.dbg to cygwin1.dll.dbg
>>
>> As far as releases go, this is ok.  I'll just have to tweak the next
>> cygport file slightly.
>>
>> Chris might have to tweak the snapshot generation script as well, so
>> he probably wants to chime in, too.
>
> It's more than just a tweak.  I've known that there is a discrepancy for
> a long time but haven't considered it that big a deal.  I'd prefer that
> this change not be made.

Fair enough.  Patch withdrawn.