public inbox for cygwin-patches@cygwin.com
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: cygwin-patches@cygwin.com
Subject: Re: [PATCH] Hide sethostname() in unistd.h
Date: Wed, 17 Jun 2015 21:15:00 -0000	[thread overview]
Message-ID: <5581E384.9030608@redhat.com> (raw)
In-Reply-To: <1434574654.11212.4.camel@cygwin.com>

[-- Attachment #1: Type: text/plain, Size: 1112 bytes --]

On 06/17/2015 02:57 PM, Yaakov Selkowitz wrote:
> On Wed, 2015-06-17 at 22:25 +0200, Christian Franke wrote:
>> Busybox does not use autoconf or similar. It requires manual platform 
>> specific configuration which does not yet support a missing 
>> sethostname(). After adding HAVE_SETHOSTNAME manually and some other 
>> minor additions, busybox (which many commands enabled) compiles and 
>> works reasonably.
>> Would ITP make sense ?
> 
> TBH I'm not sure.  Presuming you're discussing the single-executable
> build (so as not to clobber coreutils etc.), there is still the question
> of (not) matching the heavily-patched coreutils wrt .exe handling etc.
> What do you think the use case would be?

Portability testing is one thing - I often compare how
bash/dash/zsh/mksh handle a shell construct, and adding busybox sh into
the mix adds another perspective.  But yeah, I don't see busybox
becoming the default source of these apps, so much as an alternative
implementation.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]

  reply	other threads:[~2015-06-17 21:15 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-16 16:27 Christian Franke
2015-06-16 17:45 ` Corinna Vinschen
2015-06-17  5:39   ` Christian Franke
2015-06-17  8:46     ` Corinna Vinschen
2015-06-17 20:25       ` Christian Franke
2015-06-17 20:57         ` Yaakov Selkowitz
2015-06-17 21:15           ` Eric Blake [this message]
2015-06-18  8:26             ` Corinna Vinschen
2015-06-19  5:28               ` Christian Franke
2015-06-19  8:20                 ` Corinna Vinschen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5581E384.9030608@redhat.com \
    --to=eblake@redhat.com \
    --cc=cygwin-patches@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).