From: Ken Brown <kbrown@cornell.edu>
To: cygwin-patches@cygwin.com
Subject: Re: [PATCH] Cygwin: remove most occurrences of __stdcall, WINAPI, and, __cdecl
Date: Tue, 7 Jun 2022 14:00:18 -0400 [thread overview]
Message-ID: <5908d277-7ebf-70f6-1f92-573872b61e7b@cornell.edu> (raw)
In-Reply-To: <20220608014916.df0275787115d55138757a3c@nifty.ne.jp>
On 6/7/2022 12:49 PM, Takashi Yano wrote:
> _dll_crt0() is declared as
> extern void __stdcall _dll_crt0 ()
> __declspec (dllimport) __attribute__ ((noreturn));
> in winsup/cygwin/lib/cygwin_crt0.c, however, this patch
> removes __stdcall from winsup.h and dcrt0.cc as follows.
[...]
> To be consistent these, shouldn't _dll_crt0() retain __stdcall?
>
> Changing cygwin_crt0.c is a bit weird because it looks as if
> it might affect binary compatibility, even if it really doesn't.
Thanks for catching this. It was actually an accident that I didn't remove
__stdcall from cygwin_crt0.c, but I agree that it's better to retain it in the
other two places. I've fixed this.
Ken
next prev parent reply other threads:[~2022-06-07 18:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-03 14:00 Ken Brown
2022-06-05 20:24 ` Jon Turney
2022-06-05 22:23 ` Ken Brown
2022-06-06 0:02 ` Takashi Yano
2022-06-06 16:24 ` Ken Brown
2022-06-06 23:21 ` Takashi Yano
2022-06-07 16:49 ` Takashi Yano
2022-06-07 18:00 ` Ken Brown [this message]
2022-06-06 10:41 ` Jon Turney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5908d277-7ebf-70f6-1f92-573872b61e7b@cornell.edu \
--to=kbrown@cornell.edu \
--cc=cygwin-patches@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).