From: Christian Franke <Christian.Franke@t-online.de>
To: cygwin-patches@cygwin.com
Subject: Re: [PATCH] Cygwin: introduce close_range
Date: Sun, 14 Jan 2024 19:53:27 +0100 [thread overview]
Message-ID: <6b1723b1-12b1-a240-ff22-1f0f5ba73214@t-online.de> (raw)
In-Reply-To: <3ab13e94-fd3a-41c8-8392-fcd72042d0e9@dronecode.org.uk>
Jon Turney wrote:
> On 14/01/2024 16:07, Christian Franke wrote:
>> Recently I learned about the existence and usefulness of close_range():
>> https://github.com/smartmontools/smartmontools/issues/235
>>
>> https://man.freebsd.org/cgi/man.cgi?query=close_range&sektion=2
>> https://man7.org/linux/man-pages/man2/close_range.2.html
>>
>> Note that the above Linux man page is not fully correct. The include
>> file "linux/close_range.h" exists, but provides only the defines. It
>> is sufficient to include "unistd.h" as on FreeBSD.
>>
>> The attached patch adds this to Cygwin. It does not implement the
>> Linux-specific CLOSE_RANGE_UNSHARE as I have no idea how to do this :-)
>
> This API should also be mentioned in the
> "System interfaces compatible with GNU or Linux extensions" section of
> doc/posix.xml
>
>
Thanks for the info. I used the recent "Cygwin: introduce fallocate(2)"
patch as a blueprint for which other files should be changed (fallocate
is also missing in the posix.xml file).
I will provide a new patch soon which also fixes an unlikely but
possible corner case: Pass a value larger than MAX_INT as lower limit.
next prev parent reply other threads:[~2024-01-14 18:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-14 16:07 Christian Franke
2024-01-14 17:30 ` Jon Turney
2024-01-14 18:53 ` Christian Franke [this message]
2024-01-15 8:56 ` Christian Franke
2024-01-15 10:44 ` Corinna Vinschen
2024-01-15 11:19 ` Christian Franke
2024-01-15 12:07 ` Corinna Vinschen
2024-01-15 12:08 ` Corinna Vinschen
2024-01-15 12:41 ` Christian Franke
2024-01-15 12:56 ` Corinna Vinschen
2024-01-15 9:50 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b1723b1-12b1-a240-ff22-1f0f5ba73214@t-online.de \
--to=christian.franke@t-online.de \
--cc=cygwin-patches@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).