From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from 4.mo178.mail-out.ovh.net (4.mo178.mail-out.ovh.net [46.105.49.171]) by sourceware.org (Postfix) with ESMTPS id 380123AAA0ED for ; Mon, 18 Jan 2021 12:40:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 380123AAA0ED Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=wijen.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=ben@wijen.net Received: from player728.ha.ovh.net (unknown [10.109.146.131]) by mo178.mail-out.ovh.net (Postfix) with ESMTP id BA8C3C0E6F for ; Mon, 18 Jan 2021 13:40:19 +0100 (CET) Received: from wijen.net (80-112-22-40.cable.dynamic.v4.ziggo.nl [80.112.22.40]) (Authenticated sender: ben@wijen.net) by player728.ha.ovh.net (Postfix) with ESMTPSA id C2E631A0D5D58 for ; Mon, 18 Jan 2021 12:40:18 +0000 (UTC) Authentication-Results: garm.ovh; auth=pass (GARM-97G00253e69c74-f54f-42e9-b561-07d14d823fa7, 1E059570D1A9E336F11081F47AF01A3014A153AE) smtp.auth=ben@wijen.net X-OVh-ClientIp: 80.112.22.40 Subject: Re: [PATCH 02/11] syscalls.cc: Deduplicate _remove_r To: Corinna Vinschen via Cygwin-patches References: <20210115134534.13290-1-ben@wijen.net> <20210115134534.13290-3-ben@wijen.net> <20210118105603.GS59030@calimero.vinschen.de> From: Ben Message-ID: <6de2f124-c5dd-34cb-1914-4eb0454b41d8@wijen.net> Date: Mon, 18 Jan 2021 13:40:17 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210118105603.GS59030@calimero.vinschen.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Ovh-Tracer-Id: 9345813652709852932 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduledrtdekgdegfecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefuvfhfhffkffgfgggjtgfgsehtjeertddtfeejnecuhfhrohhmpeeuvghnuceosggvnhesfihijhgvnhdrnhgvtheqnecuggftrfgrthhtvghrnhepvefhgefghfdvueekgeejteevgffgtdeljeelhfffvdejffeigeeuveefueetteeunecukfhppedtrddtrddtrddtpdektddrudduvddrvddvrdegtdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhhouggvpehsmhhtphdqohhuthdphhgvlhhopehplhgrhigvrhejvdekrdhhrgdrohhvhhdrnhgvthdpihhnvghtpedtrddtrddtrddtpdhmrghilhhfrhhomhepsggvnhesfihijhgvnhdrnhgvthdprhgtphhtthhopegthihgfihinhdqphgrthgthhgvshestgihghifihhnrdgtohhm X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: cygwin-patches@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin core component patch submission and discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Jan 2021 12:40:22 -0000 On 18-01-2021 11:56, Corinna Vinschen via Cygwin-patches wrote: > Hmm, you're adding another function call to the call stack. Doesn't > that slow down _remove_r rather than speeding it up? Ok, this function > is called from _tmpfile_r/_tmpfile64_r only, so dedup may trump speed > here... > > What's your stance? > While I could do without: In an earlier version I had changed remove and missed remove_r. So, this commit is more about de-duplication rather than speed. Ben...