From: Ken Brown <kbrown@cornell.edu>
To: Jon Turney <jon.turney@dronecode.org.uk>, cygwin-patches@cygwin.com
Subject: Re: [PATCH 11/11] Ensure temporary directory used by tests exists
Date: Sun, 8 Nov 2020 13:19:45 -0500 [thread overview]
Message-ID: <8e13e92f-7aca-65ee-8978-d0b6cd7b062f@cornell.edu> (raw)
In-Reply-To: <20201105194748.31282-12-jon.turney@dronecode.org.uk>
On 11/5/2020 2:47 PM, Jon Turney wrote:
> +# temporary directory to be used for files created by tests (as an absolute,
> +# /cygdrive path, so it can be understood by the test DLL, which will have
> +# different mount table)
> +tmpdir = $(shell cygpath -ma $(objdir)/testsuite/tmp/ | sed -e 's#^\([A-Z]\):#/cygdrive/\L\1#')
This isn't right if the cygdrive prefix is not 'cygdrive'. Maybe use
'proc/cygdrive' instead of 'cygdrive'?
Ken
next prev parent reply other threads:[~2020-11-08 18:20 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-05 19:47 [PATCH 00/11] testsuite refurbishment Jon Turney
2020-11-05 19:47 ` [PATCH 01/11] Add testsuite directory to autogen.sh Jon Turney
2020-11-05 19:47 ` [PATCH 02/11] Always configure in testsuite subdirectory Jon Turney
2020-11-05 19:47 ` [PATCH 03/11] Add rule to testsuite Makefile to regenerate it when needed Jon Turney
2020-11-05 19:47 ` [PATCH 04/11] Avoid 'Makefile.in seems to ignore the --datarootdir setting' warning Jon Turney
2020-11-05 19:47 ` [PATCH 05/11] Move adding libltp to VPATH after Makefile.common Jon Turney
2020-11-05 19:47 ` [PATCH 06/11] Define target_builddir autoconf and Makefile variables Jon Turney
2020-11-05 19:47 ` [PATCH 07/11] Detect and use MinGW compilers for testsuite wrappers Jon Turney
2020-11-05 19:47 ` [PATCH 08/11] Use absolute path to libltp includes Jon Turney
2020-11-05 19:47 ` [PATCH 09/11] Check exit code of a test, rather than stdout Jon Turney
2020-11-05 19:47 ` [PATCH 10/11] Set PATH for tests to pick up cygwin0.dll Jon Turney
2020-11-05 19:47 ` [PATCH 11/11] Ensure temporary directory used by tests exists Jon Turney
2020-11-08 18:19 ` Ken Brown [this message]
2020-11-08 18:52 ` Jon Turney
2020-11-08 19:27 ` Ken Brown
2020-11-08 23:38 ` Brian Inglis
2020-11-09 16:25 ` Jon Turney
2020-11-09 17:48 ` Ken Brown
2020-11-09 21:01 ` Jon Turney
2020-11-06 9:44 ` [PATCH 00/11] testsuite refurbishment Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e13e92f-7aca-65ee-8978-d0b6cd7b062f@cornell.edu \
--to=kbrown@cornell.edu \
--cc=cygwin-patches@cygwin.com \
--cc=jon.turney@dronecode.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).