From: Ken Brown <kbrown@cornell.edu>
To: cygwin-patches@cygwin.com
Subject: Re: [PATCH 7/7] Cygwin: remove miscellaneous 32-bit code
Date: Thu, 9 Jun 2022 15:04:29 -0400 [thread overview]
Message-ID: <97cc06bf-913b-864f-673d-71dc8dfbc64c@cornell.edu> (raw)
In-Reply-To: <d4c98759c0e3d7fcc72e13566d7c00d71a52bb52.camel@cygwin.com>
On 6/9/2022 12:00 PM, Yaakov Selkowitz wrote:
> On Thu, 2022-06-09 at 17:23 +0200, Corinna Vinschen wrote:
>> On May 29 17:26, Ken Brown wrote:
>>> On 5/29/2022 9:39 AM, Jon Turney wrote:
>>>> On 26/05/2022 20:17, Ken Brown wrote:
>>>>> winsup/cygwin/autoload.cc | 136 ---------------------
>>>>> --
>>>>
>>>> Looks good.
>>>>
>>>> I think that perhaps the stdcall decoration number n is unused on
>>>> x86_64, so can be removed also in a followup?
>>>
>>> Thanks, I missed that.
>>>
>>> Also, I guess most or all of the uses of __stdcall and __cdecl can be
>>> removed from the code.
>>
>> Yes, that's right, given there's only one calling convention on 64 bit.
>>
>> I have a minor objection in terms of this patch.
>>
>> When implementing support for AMD64, there were basically 2 problems to
>> solve. One of them was to support 64 bit systems, the other one was to
>> support AMD64. At that time, only IA-64 and AMD64 64 bit systems
>> existed, and since we never considered IA-64 to run Cygwin on, we
>> subsumed all 64 bit code paths under the __x86_64__ macro.
>>
>> But should we *ever* support ARM64, as unlikely as it is, we have to
>> make sure to find all the places where the code is specificially AMD64.
>> That goes, for instance, for all places calling assembler code, or
>> for exception handling accessing CPU registers, etc.
>>
>> I'm open to discussion, but I think the code being CPU-specific
>> should still be enclosed into #ifdef __x86_64__ brackets, with an
>> #else #error alternative.
>>
>> Right? Wrong? Useless complication?
>
> Highly recommended.
OK, I'll make that change.
Ken
next prev parent reply other threads:[~2022-06-09 19:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-26 19:17 Ken Brown
2022-05-29 13:39 ` Jon Turney
2022-05-29 21:26 ` Ken Brown
2022-06-09 15:23 ` Corinna Vinschen
2022-06-09 16:00 ` Yaakov Selkowitz
2022-06-09 19:04 ` Ken Brown [this message]
2022-06-11 12:29 ` Takashi Yano
2022-06-11 12:58 ` Ken Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97cc06bf-913b-864f-673d-71dc8dfbc64c@cornell.edu \
--to=kbrown@cornell.edu \
--cc=cygwin-patches@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).