From: Mingye Wang <arthur2e5@aosc.io>
To: cygwin-patches@cygwin.com
Subject: Re: [PATCH v6] Cygwin: rewrite cmdline parser
Date: Thu, 13 May 2021 21:28:06 +0800 [thread overview]
Message-ID: <984787f1-c810-5b9a-3493-a665230bb0b0@aosc.io> (raw)
In-Reply-To: <20210513131527.14904-1-arthur2e5@aosc.io>
Oh, I should also mention that this patch does *not* fix globbing with
Windows paths. Although stuff like (in node-js):
child_process.spawnSync("C:\\cygwin64\\bin\\echo.exe",
["C:\\Qt\\*"], {encoding: 'utf-8'})
is correctly fed to glob(3), the glob() function does not perform any
interpretation of Windows paths. The older parser have the same
behavior and I didn't change that, seeing there are two ways this can
play out:
* Cygwin goes to extend glob() with the ability to do Windows paths
under a new flag. Globify() is modified to use that flag too.
* Cygwin does not extend glob(), so globify() is modified to skip on
is_dos_path much like how it already skips with a strpbrk.
Regards,
Artoria2e5
next prev parent reply other threads:[~2021-05-13 13:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-05 5:27 [PATCH v4 1/3] Cygwin: rewrite and make public " Mingye Wang
2020-09-05 5:27 ` [PATCH v4 2/3] regparm: make code highlight happy Mingye Wang
2020-09-07 9:11 ` Corinna Vinschen
2020-09-05 5:27 ` [PATCH v4 3/3] testsuite: don't strip dir from obj files Mingye Wang
2020-09-07 9:14 ` Corinna Vinschen
2020-11-07 12:12 ` [PATCH v5] Cygwin: rewrite cmdline parser Mingye Wang
2020-11-07 12:12 ` [PATCH] " Mingye Wang
2020-11-09 10:04 ` Corinna Vinschen
2021-05-13 13:15 ` [PATCH v6] " Mingye Wang
2021-05-13 13:28 ` Mingye Wang [this message]
2021-05-14 19:38 ` Johannes Schindelin
2021-05-17 11:03 ` Corinna Vinschen
2020-09-07 9:39 ` [PATCH v4 1/3] Cygwin: rewrite and make public " Corinna Vinschen
2020-09-24 8:39 ` Mingye Wang (Artoria2e5)
2020-10-13 12:14 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=984787f1-c810-5b9a-3493-a665230bb0b0@aosc.io \
--to=arthur2e5@aosc.io \
--cc=cygwin-patches@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).