* Forgotted appersand
@ 2013-04-02 8:46 Алексей Павлов
2013-04-02 9:09 ` Corinna Vinschen
0 siblings, 1 reply; 2+ messages in thread
From: Алексей Павлов @ 2013-04-02 8:46 UTC (permalink / raw)
To: cygwin-patches
Hi!
On cygwin-64bit-branch I think one appersand is forgotten.
--- a/winsup/cygwin/fhandler_disk_file.cc
+++ b/winsup/cygwin/fhandler_disk_file.cc
@@ -1176,7 +1176,7 @@ fhandler_disk_file::ftruncate (off_t length,
bool allow_truncate)
/* Create sparse files only when called through ftruncate, not when
called through posix_fallocate. */
if (allow_truncate && pc.support_sparse ()
- & !has_attribute (FILE_ATTRIBUTE_SPARSE_FILE)
+ && !has_attribute (FILE_ATTRIBUTE_SPARSE_FILE)
&& length >= fsi.EndOfFile.QuadPart + (128 * 1024))
{
status = NtFsControlFile (get_handle (), NULL, NULL, NULL, &io,
Best regards,
Alexey.
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: Forgotted appersand
2013-04-02 8:46 Forgotted appersand Алексей Павлов
@ 2013-04-02 9:09 ` Corinna Vinschen
0 siblings, 0 replies; 2+ messages in thread
From: Corinna Vinschen @ 2013-04-02 9:09 UTC (permalink / raw)
To: cygwin-patches
On Apr 2 12:46, ÐлекÑей Павлов wrote:
> Hi!
> On cygwin-64bit-branch I think one appersand is forgotten.
>
> --- a/winsup/cygwin/fhandler_disk_file.cc
> +++ b/winsup/cygwin/fhandler_disk_file.cc
> @@ -1176,7 +1176,7 @@ fhandler_disk_file::ftruncate (off_t length,
> bool allow_truncate)
> /* Create sparse files only when called through ftruncate, not when
> called through posix_fallocate. */
> if (allow_truncate && pc.support_sparse ()
> - & !has_attribute (FILE_ATTRIBUTE_SPARSE_FILE)
> + && !has_attribute (FILE_ATTRIBUTE_SPARSE_FILE)
> && length >= fsi.EndOfFile.QuadPart + (128 * 1024))
> {
> status = NtFsControlFile (get_handle (), NULL, NULL, NULL, &io,
Thanks for catching! I just applied the patch.
Thanks,
Corinna
--
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Maintainer cygwin AT cygwin DOT com
Red Hat
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-04-02 9:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-04-02 8:46 Forgotted appersand Алексей Павлов
2013-04-02 9:09 ` Corinna Vinschen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).