public inbox for cygwin-patches@cygwin.com
 help / color / mirror / Atom feed
From: Alexey Pavlov <alexpux@gmail.com>
To: cygwin-patches@cygwin.com
Subject: Re: braces around scalar initializer for type
Date: Fri, 13 Mar 2015 10:04:00 -0000	[thread overview]
Message-ID: <CABEPuQLGt+wvApfuDGihQoPf2SodQwBR3iCWdfgRK7VkneBOQQ@mail.gmail.com> (raw)
In-Reply-To: <20150313094412.GA20626@calimero.vinschen.de>

2015-03-13 12:44 GMT+03:00 Corinna Vinschen <corinna-cygwin@cygwin.com>:
> Hi Alexey,
>
> On Mar 12 22:47, Alexey Pavlov wrote:
>> 2015-03-12 22:22 GMT+03:00 Corinna Vinschen:
>> > I'm ok with that patch, but it's missing the ChangeLog entry,  Please
>> > provide ChangeLog entries per https://cygwin.com/contrib.html.
>>
>> + * net.cc: Remove extra braces.
>> +
>
> Please send the ChangeLog as plain text, not as diff.  It's not much of
> a problem in our current case, but ChangeLog diff's don't apply cleanly
> most of the time.

Ok will do next time.
>
>> -const struct in6_addr in6addr_any = {{IN6ADDR_ANY_INIT}};
>> -const struct in6_addr in6addr_loopback = {{IN6ADDR_LOOPBACK_INIT}};
>> +const struct in6_addr in6addr_any = IN6ADDR_ANY_INIT;
>> +const struct in6_addr in6addr_loopback = IN6ADDR_LOOPBACK_INIT;
>
> Patch applied.
>

Thanks!
>
> Thanks,
> Corinna
>
> --
> Corinna Vinschen                  Please, send mails regarding Cygwin to
> Cygwin Maintainer                 cygwin AT cygwin DOT com
> Red Hat

      reply	other threads:[~2015-03-13 10:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-12 18:18 Alexey Pavlov
2015-03-12 19:22 ` Corinna Vinschen
2015-03-12 19:47   ` Alexey Pavlov
2015-03-13  9:44     ` Corinna Vinschen
2015-03-13 10:04       ` Alexey Pavlov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CABEPuQLGt+wvApfuDGihQoPf2SodQwBR3iCWdfgRK7VkneBOQQ@mail.gmail.com \
    --to=alexpux@gmail.com \
    --cc=cygwin-patches@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).