From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <cygwin-patches-return-8236-listarch-cygwin-patches=sources.redhat.com@cygwin.com>
Received: (qmail 10397 invoked by alias); 17 Aug 2015 08:02:50 -0000
Mailing-List: contact cygwin-patches-help@cygwin.com; run by ezmlm
Precedence: bulk
List-Id: <cygwin-patches.cygwin.com>
List-Subscribe: <mailto:cygwin-patches-subscribe@cygwin.com>
List-Post: <mailto:cygwin-patches@cygwin.com>
List-Archive: <http://sourceware.org/ml/cygwin-patches/>
List-Help: <mailto:cygwin-patches-help@cygwin.com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-patches-owner@cygwin.com
Mail-Followup-To: cygwin-patches@cygwin.com
Received: (qmail 10386 invoked by uid 89); 17 Aug 2015 08:02:49 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mail-wi0-f173.google.com
Received: from mail-wi0-f173.google.com (HELO mail-wi0-f173.google.com) (209.85.212.173) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 17 Aug 2015 08:02:48 +0000
Received: by wibhh20 with SMTP id hh20so73390192wib.0        for <cygwin-patches@cygwin.com>; Mon, 17 Aug 2015 01:02:45 -0700 (PDT)
MIME-Version: 1.0
X-Received: by 10.180.85.194 with SMTP id j2mr31228435wiz.11.1439798565203; Mon, 17 Aug 2015 01:02:45 -0700 (PDT)
Received: by 10.28.51.80 with HTTP; Mon, 17 Aug 2015 01:02:45 -0700 (PDT)
In-Reply-To: <20150817075954.GB25127@calimero.vinschen.de>
References: <CAGHpTBLBua-DJQ1tBapYd_6ypdWGMW+ehAq4r7k_TA44Tn_Oxg@mail.gmail.com>	<20150817075954.GB25127@calimero.vinschen.de>
Date: Mon, 17 Aug 2015 08:02:00 -0000
Message-ID: <CAGHpTBJaZmtKq_NvXgjVEz9QLv6siK9CdHBK+FXAn0Pb1iMfBw@mail.gmail.com>
Subject: Re: [PATCH] mkglobals: Fix EOL detection
From: Orgad Shaneh <orgads@gmail.com>
To: cygwin-patches@cygwin.com
Content-Type: text/plain; charset=UTF-8
X-IsSubscribed: yes
X-SW-Source: 2015-q3/txt/msg00018.txt.bz2

On Mon, Aug 17, 2015 at 10:59 AM, Corinna Vinschen
<corinna-cygwin@cygwin.com> wrote:
> On Aug 17 10:41, Orgad Shaneh wrote:
>> When globals.cc has CRLF line endings, winsup.h is not removed, and
>> compilation fails for duplicate definitions.
>
> Why on earth should globals.h get CRLF line endings?  It's stored
> with LF line endings in git.  There's no reason to convert the file.

globals.h is generated, I guess you refer to globals.cc.

Well, git has a setting named core.autocrlf which converts
line-endings to CRLF on Windows.

This is very commonly used with msysGit and Git for Windows.

If the cygwin repository is cloned with autocrlf set, then all the
source files will have CRLF line endings, including globals.cc...

- Orgad