From: Orgad Shaneh <orgads@gmail.com>
To: cygwin-patches@cygwin.com
Subject: Re: [PATCH] mkglobals: Fix EOL detection
Date: Mon, 17 Aug 2015 08:21:00 -0000 [thread overview]
Message-ID: <CAGHpTBKF_VfGRBxg2J1W=zamF-meYxTgRbGvoa-3i5BN3hb1OQ@mail.gmail.com> (raw)
In-Reply-To: <20150817081508.GG25127@calimero.vinschen.de>
On Mon, Aug 17, 2015 at 11:15 AM, Corinna Vinschen
<corinna-cygwin@cygwin.com> wrote:
> On Aug 17 11:02, Orgad Shaneh wrote:
>> On Mon, Aug 17, 2015 at 10:59 AM, Corinna Vinschen
>> <corinna-cygwin@cygwin.com> wrote:
>> > On Aug 17 10:41, Orgad Shaneh wrote:
>> >> When globals.cc has CRLF line endings, winsup.h is not removed, and
>> >> compilation fails for duplicate definitions.
>> >
>> > Why on earth should globals.h get CRLF line endings? It's stored
>> > with LF line endings in git. There's no reason to convert the file.
>>
>> globals.h is generated, I guess you refer to globals.cc.
>>
>> Well, git has a setting named core.autocrlf which converts
>> line-endings to CRLF on Windows.
>>
>> This is very commonly used with msysGit and Git for Windows.
>>
>> If the cygwin repository is cloned with autocrlf set, then all the
>> source files will have CRLF line endings, including globals.cc...
>
> You should set core.autocrlf to no in Cygwin's local git config.
Well, I don't see that in the FAQ[1].
Is there a reason *not* to accept this patch? It's merely reordering
substitutions...
- Orgad
[1] https://cygwin.com/faq/faq.html#faq.programming.building-cygwin
next prev parent reply other threads:[~2015-08-17 8:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-17 7:42 Orgad Shaneh
2015-08-17 7:59 ` Corinna Vinschen
2015-08-17 8:02 ` Orgad Shaneh
2015-08-17 8:15 ` Corinna Vinschen
2015-08-17 8:21 ` Orgad Shaneh [this message]
2015-08-17 9:06 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGHpTBKF_VfGRBxg2J1W=zamF-meYxTgRbGvoa-3i5BN3hb1OQ@mail.gmail.com' \
--to=orgads@gmail.com \
--cc=cygwin-patches@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).