From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x536.google.com (mail-pg1-x536.google.com [IPv6:2607:f8b0:4864:20::536]) by sourceware.org (Postfix) with ESMTPS id 6F0D2385841A for ; Tue, 6 Jun 2023 01:14:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6F0D2385841A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pg1-x536.google.com with SMTP id 41be03b00d2f7-53063897412so5127346a12.0 for ; Mon, 05 Jun 2023 18:14:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686014071; x=1688606071; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=WAxu64fbjzD1qJxitNgWQDhe2OaA2YWXXoiCGY9yM9A=; b=gWNSIHFxyRBfhM3WvsxD9+OGC/w94KGko8DduOS5XYyPgs+V7v5UvkkCffF5J51JR6 BguW5Mhjxtlt3UiqLn7H0GfLok2kD9YOmId+8eJEE3sQhkgfhMuu0tztVxEUaZYMDpOK dLPSdYAqDLy2+D9esW7GMyt68yFURMLTW+WEfJx7kFav9qyVyEx4B4sJz2chEuBFxyDz AYeie3Y0LaGYRIbAodtzfXl0l2U4KT3M+QRtq8bnI1QAsTaRuyDTSSf8lkmCDTWGBl6C T9p3ZhYZSuVATVkgtoPLc/1J6g54CSp9EGLLsZOBH5U65xFIt7TqNLe8f0mahggH2Fj3 63lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686014071; x=1688606071; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WAxu64fbjzD1qJxitNgWQDhe2OaA2YWXXoiCGY9yM9A=; b=TYOvLx4AsjKpZUDHUXoqtD5iXrWROZmcYdfanjSy0Np8JXuDDQWicSjxrQdaD+mcAn zrSYHiYCDuT63HEhIDu1CDSjdZgG4/spSv4oz1YfejVDnkqjwAbC72UAXPdZ8ACyxvVx X3H/rSVssfyN5RmyXMRm04n6USWcJ8rH9X/Ho/sfQiovRiOYh1G2oCZQXDtXY6C7CybC 8f1VGsQixx+ztGh5bnrPu9F5U8Dy/iGbuQZ2LtogEDbM2StIOAC7ymmpQq9gB7noQW8N Gpt3qq/vR/6CZeB2rtaDdLjS7QQuQfaNjBQodBeN9KmvPoRPF8C3knWtHcZMrB8q0mMI e3aw== X-Gm-Message-State: AC+VfDwJ02IyPH50SHdUx57ziZRyjJs5F9T2J82E29ZNH5ISFOd5KRuP woFL8h1IMD187hwdbd/wiL0lvtlwVUJTvA0jhnJAZrNVep8= X-Google-Smtp-Source: ACHHUZ7sfbXaCMxSYVFFv8gZecqp+8cCpJ7VZlAFsr4QcRFIQ6Lje1Nxh3PKEW8SbEGC1CmI/fIw1kqIOMjyAHEOkqc= X-Received: by 2002:a17:902:c94d:b0:1b0:6038:2982 with SMTP id i13-20020a170902c94d00b001b060382982mr706356pla.41.1686014071190; Mon, 05 Jun 2023 18:14:31 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Philippe Cerfon Date: Tue, 6 Jun 2023 03:14:20 +0200 Message-ID: Subject: Re: [PATCH] include/cygwin/limits.h: add XATTR_{NAME,SIZE,LIST}_MAX To: cygwin-patches@cygwin.com Content-Type: multipart/mixed; boundary="000000000000ccd5ad05fd6bbd53" X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000ccd5ad05fd6bbd53 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hey Corinna, et al. On Mon, Jun 5, 2023 at 9:05=E2=80=AFPM Corinna Vinschen wrote: > - Whatever that's good for, we actually allow bigger values right > now. For compat reasons we only allow attributes starting with > the "user." prefix, and the *trailing* part after "user." is > allowed to be 255 bytes long, because we don't store the "user." > prefix in the EA name on disk. So in fact, XATTR_NAME_MAX should > be 255 + strlen("user.") =3D=3D 260. I haven't given to much though into that right now (just about to go for 2 weeks on vacation), but if "we" (Cygwin) allow now names up to 260 bytes, because we don't store the "user." .. doesn't that mean users could set XATTRs, that in the end couldn't be read by e.g. Linux (should there be, or ever be in the future, support for reading FAT/NTFS' EAs as XATTRs.... e.g. from the Linux FAT/NTFS fs drivers)? > - If we actually define these values in limits.h, it would also be a > good idea to use them in ntea.cc and to throw away the MAX_EA_*_LEN > macros. Done so in a 2nd commit. But that commit, right now, really just replaces the name! MAX_EA_NAME_LEN was set 256, so presumably with the null terminator... while now it would be set to 260, which seems wrong. Please just adapt if necessary,... or at least I won't likely be able to update the patch until in about 2 weeks or so. Thanks, Philippe --000000000000ccd5ad05fd6bbd53 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Cygwin-export-XATTR_-NAME-SIZE-LIST-_MAX.patch" Content-Disposition: attachment; filename="0001-Cygwin-export-XATTR_-NAME-SIZE-LIST-_MAX.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lijl81320 RnJvbSBiNjRiOWE0OGM3NzMyNmVkMjU0NGU1MTQyMmFkYmUxZjFjNjMxNTQyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBDZXJmb24gPHBoaWxjZXJmQGdtYWlsLmNvbT4K RGF0ZTogVHVlLCAzMCBNYXkgMjAyMyAxMzoxNjoxOCArMDIwMApTdWJqZWN0OiBbUEFUQ0ggMS8y XSBDeWd3aW46IGV4cG9ydCBYQVRUUl97TkFNRSxTSVpFLExJU1R9X01BWAoKVGhlc2UgYXJlIHVz ZWQgZm9yIGV4YW1wbGUgYnkgQ1B5dGhvbi4KClNpZ25lZC1vZmYtYnk6IFBoaWxpcHBlIENlcmZv biA8cGhpbGNlcmZAZ21haWwuY29tPgpTaWduZWQtb2ZmLWJ5OiBDb3Jpbm5hIFZpbnNjaGVuIDxj b3Jpbm5hQHZpbnNjaGVuLmRlPgotLS0KIHdpbnN1cC9jeWd3aW4vaW5jbHVkZS9jeWd3aW4vbGlt aXRzLmggfCA3ICsrKysrKysKIDEgZmlsZSBjaGFuZ2VkLCA3IGluc2VydGlvbnMoKykKCmRpZmYg LS1naXQgYS93aW5zdXAvY3lnd2luL2luY2x1ZGUvY3lnd2luL2xpbWl0cy5oIGIvd2luc3VwL2N5 Z3dpbi9pbmNsdWRlL2N5Z3dpbi9saW1pdHMuaAppbmRleCBhZWZjN2M3YmQuLmVhM2UyODM2YSAx MDA2NDQKLS0tIGEvd2luc3VwL2N5Z3dpbi9pbmNsdWRlL2N5Z3dpbi9saW1pdHMuaAorKysgYi93 aW5zdXAvY3lnd2luL2luY2x1ZGUvY3lnd2luL2xpbWl0cy5oCkBAIC01Niw0ICs1NiwxMSBAQCBk ZXRhaWxzLiAqLwogI2RlZmluZSBfX1BBVEhfTUFYIDQwOTYKICNkZWZpbmUgX19QSVBFX0JVRiA0 MDk2CiAKKy8qIFhBVFRSX05BTUVfTUFYIGlzIHRoZSBtYXhpbXVtIFhBVFRSIG5hbWUgbGVuZ3Ro IGV4Y2x1ZGluZyB0aGUgbnVsbAorICogdGVybWluYXRvci4gU2luY2Ugb25seSBYQVRUUnMgaW4g dGhlIGB1c2VyJyBuYW1lc3BhY2UgYXJlIGFsbG93ZWQgYW5kIHRoZQorICogYHVzZXIuJyBwcmVm aXggaXMgbm90IHN0b3JlZCwgdGhlIG1heGltdW0gaXMgaW5jcmVhc2VkIGJ5IDUuICovCisjZGVm aW5lIFhBVFRSX05BTUVfTUFYIDI2MAorI2RlZmluZSBYQVRUUl9TSVpFX01BWCA2NTUzNgorI2Rl ZmluZSBYQVRUUl9MSVNUX01BWCA2NTUzNgorCiAjZW5kaWYgLyogX0NZR1dJTl9MSU1JVFNfSF9f ICovCi0tIAoyLjQwLjEKCg== --000000000000ccd5ad05fd6bbd53 Content-Type: text/x-patch; charset="US-ASCII"; name="0002-Cygwin-use-new-XATTR_-NAME-SIZE-_MAX-instead-of-MAX_.patch" Content-Disposition: attachment; filename="0002-Cygwin-use-new-XATTR_-NAME-SIZE-_MAX-instead-of-MAX_.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lijl813a1 RnJvbSBhODYwMjEyNTMzYjJjNDM4ODMyZWE0MTlmYzIzNTM3ZDA1ZWEyMjEwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBDZXJmb24gPHBoaWxjZXJmQGdtYWlsLmNvbT4K RGF0ZTogVHVlLCA2IEp1biAyMDIzIDAyOjUyOjQ5ICswMjAwClN1YmplY3Q6IFtQQVRDSCAyLzJd IEN5Z3dpbjogdXNlIG5ldyBYQVRUUl97TkFNRSxTSVpFfV9NQVggaW5zdGVhZCBvZgogTUFYX0VB X3tOQU1FLFZBTFVFfV9MRU4KClNpZ25lZC1vZmYtYnk6IFBoaWxpcHBlIENlcmZvbiA8cGhpbGNl cmZAZ21haWwuY29tPgotLS0KIHdpbnN1cC9jeWd3aW4vbnRlYS5jYyB8IDE4ICsrKysrKysrLS0t LS0tLS0tLQogMSBmaWxlIGNoYW5nZWQsIDggaW5zZXJ0aW9ucygrKSwgMTAgZGVsZXRpb25zKC0p CgpkaWZmIC0tZ2l0IGEvd2luc3VwL2N5Z3dpbi9udGVhLmNjIGIvd2luc3VwL2N5Z3dpbi9udGVh LmNjCmluZGV4IGE0MDBmY2IyYi4uYWFmZWNkZTU5IDEwMDY0NAotLS0gYS93aW5zdXAvY3lnd2lu L250ZWEuY2MKKysrIGIvd2luc3VwL2N5Z3dpbi9udGVhLmNjCkBAIC0xNyw5ICsxNyw3IEBAIGRl dGFpbHMuICovCiAjaW5jbHVkZSAidGxzX3BidWYuaCIKICNpbmNsdWRlIDxzdGRsaWIuaD4KICNp bmNsdWRlIDxhdHRyL3hhdHRyLmg+Ci0KLSNkZWZpbmUgTUFYX0VBX05BTUVfTEVOICAgIDI1Ngot I2RlZmluZSBNQVhfRUFfVkFMVUVfTEVOIDY1NTM2CisjaW5jbHVkZSA8Y3lnd2luL2xpbWl0cy5o PgogCiAvKiBBdCBsZWFzdCBvbmUgbWF4aW11bSBzaXplZCBlbnRyeSBmaXRzLgogICAgQ1YgMjAx NC0wNC0wNDogTnRRdWVyeUVhRmlsZSBmdW5jdGlvbiBjaG9rZXMgb24gYnVmZmVycyBiaWdnZXIg dGhhbiA2NEsKQEAgLTI3LDEzICsyNSwxMyBAQCBkZXRhaWxzLiAqLwogCQkgIG9uIGEgcmVtb3Rl IHNoYXJlLCBhdCBsZWFzdCBvbiBXaW5kb3dzIDcgYW5kIGxhdGVyLgogCQkgIEluIHRoZW9yeSB0 aGUgYnVmZmVyIHNob3VsZCBoYXZlIGEgc2l6ZSBvZgogCi0JCSAgICBzaXplb2YgKEZJTEVfRlVM TF9FQV9JTkZPUk1BVElPTikgKyBNQVhfRUFfTkFNRV9MRU4KLQkJICAgICsgTUFYX0VBX1ZBTFVF X0xFTgorCQkgICAgc2l6ZW9mIChGSUxFX0ZVTExfRUFfSU5GT1JNQVRJT04pICsgWEFUVFJfTkFN RV9NQVgKKwkJICAgICsgWEFUVFJfU0laRV9NQVgKIAogCQkgICg2NTgwNCBieXRlcyksIGJ1dCB3 ZSdyZSBvcHRpbmcgZm9yIHNpbXBsaWNpdHkgaGVyZSwgYW5kCiAJCSAgYSA2NEsgYnVmZmVyIGhh cyB0aGUgYWR2YW50YWdlIHRoYXQgd2UgY2FuIHVzZSBhIHRtcF9wYXRoYnVmCiAJCSAgYnVmZmVy LCByYXRoZXIgdGhhbiBoYXZpbmcgdG8gYWxsb2NhIDY0SyBmcm9tIHN0YWNrLiAqLwotI2RlZmlu ZSBFQV9CVUZTSVogTUFYX0VBX1ZBTFVFX0xFTgorI2RlZmluZSBFQV9CVUZTSVogWEFUVFJfU0la RV9NQVgKIAogI2RlZmluZSBORVhUX0ZFQShwKSAoKFBGSUxFX0ZVTExfRUFfSU5GT1JNQVRJT04p IChwLT5OZXh0RW50cnlPZmZzZXQgXAogCQkgICAgID8gKGNoYXIgKikgcCArIHAtPk5leHRFbnRy eU9mZnNldCA6IE5VTEwpKQpAQCAtNTUsNyArNTMsNyBAQCByZWFkX2VhIChIQU5ETEUgaGRsLCBw YXRoX2NvbnYgJnBjLCBjb25zdCBjaGFyICpuYW1lLCBjaGFyICp2YWx1ZSwgc2l6ZV90IHNpemUp CiAgICAgIHJldHVybnMgdGhlIGxhc3QgRUEgZW50cnkgb2YgdGhlIGZpbGUgaW5maW5pdGVseS4g IEV2ZW4gdXRpbGl6aW5nIHRoZQogICAgICBvcHRpb25hbCBFYUluZGV4IG9ubHkgaGVscHMgbWFy Z2luYWxseS4gIElmIHlvdSB1c2UgdGhhdCwgdGhlIGxhc3QKICAgICAgRUEgaW4gdGhlIGZpbGUg aXMgcmV0dXJuZWQgdHdpY2UuICovCi0gIGNoYXIgbGFzdG5hbWVbTUFYX0VBX05BTUVfTEVOXTsK KyAgY2hhciBsYXN0bmFtZVtYQVRUUl9OQU1FX01BWF07CiAKICAgX190cnkKICAgICB7CkBAIC05 NSw3ICs5Myw3IEBAIHJlYWRfZWEgKEhBTkRMRSBoZGwsIHBhdGhfY29udiAmcGMsIGNvbnN0IGNo YXIgKm5hbWUsIGNoYXIgKnZhbHVlLCBzaXplX3Qgc2l6ZSkKIAkgICAgICBfX2xlYXZlOwogCSAg ICB9CiAKLQkgIGlmICgobmxlbiA9IHN0cmxlbiAobmFtZSkpID49IE1BWF9FQV9OQU1FX0xFTikK KwkgIGlmICgobmxlbiA9IHN0cmxlbiAobmFtZSkpID49IFhBVFRSX05BTUVfTUFYKQogCSAgICB7 CiAJICAgICAgc2V0X2Vycm5vIChFSU5WQUwpOwogCSAgICAgIF9fbGVhdmU7CkBAIC0xOTcsNyAr MTk1LDcgQEAgcmVhZF9lYSAoSEFORExFIGhkbCwgcGF0aF9jb252ICZwYywgY29uc3QgY2hhciAq bmFtZSwgY2hhciAqdmFsdWUsIHNpemVfdCBzaXplKQogCQkgIC8qIEZvciBjb21wYXRpYmlsaXR5 IHdpdGggTGludXgsIHdlIGFsd2F5cyBwcmVwZW5kICJ1c2VyLiIgdG8KIAkJICAgICB0aGUgYXR0 cmlidXRlIG5hbWUsIHNvIGVmZmVjdGl2ZWx5IHdlIG9ubHkgc3VwcG9ydCB1c2VyCiAJCSAgICAg YXR0cmlidXRlcyBmcm9tIGEgYXBwbGljYXRpb24gcG9pbnQgb2Ygdmlldy4gKi8KLQkJICBjaGFy IHRtcGJ1ZltNQVhfRUFfTkFNRV9MRU4gKiAyXTsKKwkJICBjaGFyIHRtcGJ1ZltYQVRUUl9OQU1F X01BWCAqIDJdOwogCQkgIGNoYXIgKnRwID0gc3RwY3B5ICh0bXBidWYsICJ1c2VyLiIpOwogCQkg IHN0cGNweSAodHAsIGZlYS0+RWFOYW1lKTsKIAkJICAvKiBOVEZTIHN0b3JlcyBhbGwgRUEgbmFt ZXMgaW4gdXBwZXJjYXNlIHVuZm9ydHVuYXRlbHkuICBUbwpAQCAtMjk3LDcgKzI5NSw3IEBAIHdy aXRlX2VhIChIQU5ETEUgaGRsLCBwYXRoX2NvbnYgJnBjLCBjb25zdCBjaGFyICpuYW1lLCBjb25z dCBjaGFyICp2YWx1ZSwKICAgICAgIC8qIFNraXAgInVzZXIuIiBwcmVmaXguICovCiAgICAgICBu YW1lICs9IDU7CiAKLSAgICAgIGlmICgobmxlbiA9IHN0cmxlbiAobmFtZSkpID49IE1BWF9FQV9O QU1FX0xFTikKKyAgICAgIGlmICgobmxlbiA9IHN0cmxlbiAobmFtZSkpID49IFhBVFRSX05BTUVf TUFYKQogCXsKIAkgIHNldF9lcnJubyAoRUlOVkFMKTsKIAkgIF9fbGVhdmU7Ci0tIAoyLjQwLjEK Cg== --000000000000ccd5ad05fd6bbd53--