RE: [EXTERNAL] Re: [PATCH 2/7] Use matching format for NTSTATUS

["Lavrentiev, Anton (NIH/NLM/NCBI) [C]" <lavr@ncbi.nlm.nih.gov>]

So?  With %X (capital X) the alternate form has the prefix 0X capital, too; and it's really hard to read.

IDK what is exactly your point that you are trying to make, is my patch somehow incorrect, or what?

Anton Lavrentiev
Contractor NIH/NLM/NCBI

> -----Original Message-----
> From: Brian Inglis <Brian.Inglis@SystematicSw.ab.ca>
> Sent: Friday, January 14, 2022 11:38 PM
> To: cygwin-patches@cygwin.com
> Subject: [EXTERNAL] Re: [PATCH 2/7] Use matching format for NTSTATUS
> 
> CAUTION: This email originated from outside of the organization. Do not click links or
> open attachments unless you recognize the sender and are confident the content is safe.
> 
> 
> See fprintf(3p) POSIX:
> #   Specifies that the value is to be converted to an alternative form.
> ...
>      For x or X  conversion  specifiers, a non-zero result shall have 0x
> (or 0X) prefixed to it.
> 
> On 2022-01-14 15:10, Anton Lavrentiev via Cygwin-patches wrote:
> > ---
> >   winsup/cygwin/libc/minires-os-if.c | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/winsup/cygwin/libc/minires-os-if.c b/winsup/cygwin/libc/minires-os-if.c
> > index 666a008de..6e17de0b8 100644
> > --- a/winsup/cygwin/libc/minires-os-if.c
> > +++ b/winsup/cygwin/libc/minires-os-if.c
> > @@ -359,7 +359,7 @@ static void get_registry_dns(res_state statp)
> >     status = RtlCheckRegistryKey (RTL_REGISTRY_SERVICES, keyName);
> >     if (!NT_SUCCESS (status))
> >       {
> > -      DPRINTF (statp->options & RES_DEBUG, "RtlCheckRegistryKey: status %p\n",
> > +      DPRINTF (statp->options & RES_DEBUG, "RtlCheckRegistryKey: status 0x%08X\n",
>           DPRINTF (statp->options & RES_DEBUG, "RtlCheckRegistryKey:
> status %#08x\n",
> >              status);
> >         return;
> >       }
> > @@ -381,7 +381,7 @@ static void get_registry_dns(res_state statp)
> >     if (!NT_SUCCESS (status))
> >       {
> >         DPRINTF (statp->options & RES_DEBUG,
> > -            "RtlQueryRegistryValues: status %p\n", status);
> > +            "RtlQueryRegistryValues: status 0x%08x\n", status);
>                "RtlQueryRegistryValues: status %#08x\n", status);
> >         return;
> >       }
> 
> --
> Take care. Thanks, Brian Inglis, Calgary, Alberta, Canada
> 
> This email may be disturbing to some readers as it contains
> too much technical detail. Reader discretion is advised.
> [Data in binary units and prefixes, physical quantities in SI.]